Skip to content

vet: ensure all usages of grpc_testing package are renamed when importing #6595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Aug 29, 2023

RELEASE NOTES: none

@easwars easwars requested a review from dfawley August 29, 2023 20:45
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Aug 29, 2023
@easwars easwars added this to the 1.58 Release milestone Aug 29, 2023
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this needs #6594?

@dfawley dfawley assigned easwars and unassigned dfawley Aug 29, 2023
@easwars easwars force-pushed the add_vet_check_for_grpc_testing branch from 9b26619 to cb26e87 Compare August 29, 2023 20:53
@easwars
Copy link
Contributor Author

easwars commented Aug 29, 2023

I guess this needs #6594?

Yes, it does. I did a rebase after merging that. Waiting for tests to be green now.

@easwars easwars merged commit aa6ce35 into grpc:master Aug 29, 2023
@easwars easwars deleted the add_vet_check_for_grpc_testing branch August 29, 2023 22:27
ulascansenturk added a commit to ulascansenturk/grpc-go that referenced this pull request Sep 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants