Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolver: delete Target.Scheme and Target.Authority #6353

Closed
wants to merge 1 commit into from
Closed

resolver: delete Target.Scheme and Target.Authority #6353

wants to merge 1 commit into from

Conversation

ginayeh
Copy link
Contributor

@ginayeh ginayeh commented Jun 6, 2023 •
edited by dfawley
Loading

Fixes #5795

RELEASE NOTES:

  • resolver: remove deprecated Target.Scheme and Target.Authority. Use URL.Scheme and URL.Host instead, respectively

@ginayeh ginayeh linked an issue Jun 6, 2023 that may be closed by this pull request
Cleanup usages of resolver.Target.Authority #5795
Closed
@ginayeh ginayeh force-pushed the 5795-cleanup-usages-of-resolvertargetauthority branch from 6d17902 to 7a28e98 Compare June 6, 2023 20:25
@ginayeh ginayeh added this to the 1.56 Release milestone Jun 6, 2023
@ginayeh ginayeh added Type: API Change Breaking API changes (experimental APIs only!) Type: Internal Cleanup Refactors, etc labels Jun 6, 2023
@dfawley dfawley changed the title Delete resolver.Target.Scheme and resolver.Target.Authority #5795 resolver: delete Target.Scheme and Target.Authority Jun 6, 2023
dfawley
dfawley reviewed Jun 6, 2023
View reviewed changes
clientconn_parsed_target_test.go Show resolved Hide resolved
clientconn_parsed_target_test.go Show resolved Hide resolved
internal/resolver/dns/dns_resolver.go Show resolved Hide resolved
internal/resolver/dns/dns_resolver_test.go Show resolved Hide resolved
internal/resolver/dns/dns_resolver.go Show resolved Hide resolved
@dfawley dfawley removed the Type: Internal Cleanup Refactors, etc label Jun 6, 2023
@ginayeh
Copy link
Contributor Author

ginayeh commented Jun 8, 2023

Comments are addressed and send a new PR at #6363.

@ginayeh ginayeh closed this Jun 8, 2023
@arvindbr8 arvindbr8 deleted the 5795-cleanup-usages-of-resolvertargetauthority branch September 5, 2023 16:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley left review comments

Assignees

@ginayeh ginayeh

Labels
Type: API Change Breaking API changes (experimental APIs only!)
Projects
None yet
Milestone
1.56 Release
Development

Successfully merging this pull request may close these issues.

Cleanup usages of resolver.Target.Authority
2 participants
@ginayeh @dfawley