grpc: minor improvement on WithInsecure() document #5068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current document asks to replace
WithInsecure()
withinsecure.NewCredentials()
.But it causes confusion because function signatures for
WithInsecure()
andinsecure.NewCredentials()
are different.Instead, using
insecure.NewCredentials()
as a parameter forWithTransportCredentials
replicate the deprecatedWithInsecure
function.So I propose a minor improvement to mention
WithTransportCredentials
in the comment.RELEASE NOTES: None