retry: re-enable retrying on non-IO transport errors #3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
reviewed
Jun 15, 2020
| } else { | ||
| unprocessed = true | ||
| } | ||
| if !ok && !cs.callInfo.failFast { |
There was a problem hiding this comment.
In what situation would we want to fail non-wait-for-ready RPC when there's no IO?
There was a problem hiding this comment.
Per the spec, we are only allowed 1 transparent retry for non-WFR RPCs. The idea being that they should be making progress at all times.
menghanl
approved these changes
Jun 16, 2020
menghanl
pushed a commit
to menghanl/grpc-go
that referenced
this pull request
Jun 16, 2020
menghanl
added a commit
that referenced
this pull request
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes fixes a bad assumption made about NewStream, and tags PerRPCCreds errors in order to not retry on those errors but retry on others.
Must be cherry-picked into the 1.30 release branch before release.
Fixes #3686