grpclb: fallback after init #2681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
force-pushed
the
grpclb_fallback
branch
from
7404bbb to
49454d6
Compare
lyuxuan
suggested changes
Mar 26, 2019
menghanl
force-pushed
the
grpclb_fallback
branch
from
49454d6 to
e4b6b8d
Compare
lyuxuan
approved these changes
Mar 29, 2019
…se new subconn state might not be updated for cached subconns
lyuxuan
reviewed
Apr 1, 2019
| // refreshSubConns creates/removes SubConns with backendAddrs. | ||
| // | ||
| // Caller must hold lb.mu. | ||
| func (lb *lbBalancer) refreshSubConns(backendAddrs []resolver.Address, fromGRPCLBServer bool) { |
Contributor
There was a problem hiding this comment.
It seems refreshSubConns is always followed by regeneratePicker. Can we put regeneratePicker inside refreshSubConns?
Contributor
Author
There was a problem hiding this comment.
Done. Now also updates picker after regenerating picker.
lyuxuan
approved these changes
Apr 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When losing connection to remote balancer and no backend from remote balancer is Ready.