Skip to content

Run Go1.9 and 386 on Travis #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2017
Merged

Run Go1.9 and 386 on Travis #1475

merged 3 commits into from
Aug 29, 2017

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 25, 2017

Fixes #1473

@dfawley
Copy link
Member Author

dfawley commented Aug 25, 2017

Looks like Travis doesn't support Go1.9 yet:

$ GIMME_OUTPUT=$(gimme 1.9.x | tee -a $HOME/.bashrc) && eval "$GIMME_OUTPUT"
I don't have any idea what to do with '1.9.x'.
  (using type 'auto')
$ export GOPATH=$HOME/gopath
$ export PATH=$HOME/gopath/bin:$PATH
$ mkdir -p $HOME/gopath/src/google.golang.org/grpc
$ rsync -az ${TRAVIS_BUILD_DIR}/ $HOME/gopath/src/google.golang.org/grpc/
$ export TRAVIS_BUILD_DIR=$HOME/gopath/src/google.golang.org/grpc
$ cd $HOME/gopath/src/google.golang.org/grpc
0.02s
$ gimme version
v1.0.0
$ go version
go version go1.7.4 linux/amd64

But, travis-ci/travis-build#1148 just added it...

.travis.yml Outdated
@@ -19,5 +20,6 @@ script:
- 'set -o pipefail && goimports -l . 2>&1 | tee /dev/stderr | (! read)'
- 'if [[ $TRAVIS_GO_VERSION = 1.8* ]]; then ! golint ./... | grep -vE "(_mock|_string|\.pb)\.go:"; fi'
- 'if [[ $TRAVIS_GO_VERSION = 1.8* ]]; then ! go tool vet -all . 2>&1 | grep -vF .pb.go:; fi' # https://github.com/golang/protobuf/issues/214
- make test testrace
- 'make test testrace'
- 'if [[ $TRAVIS_GO_VERSION = 1.9* ]]; then ARCH=386 make test testrace; fi'
- 'if [[ $TRAVIS_GO_VERSION = 1.8* ]]; then staticcheck -ignore google.golang.org/grpc/transport/transport_test.go:SA2002 ./...; fi' # TODO(menghanl): fix these
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make this 1.9*?

@dfawley dfawley mentioned this pull request Aug 29, 2017
@HelloGrayson
Copy link
Contributor

@dfawley looks like gimme has 1.9 now:

google.golang.org/grpc-go - [go1.9] » gimme 1.9

unset GOOS;
unset GOARCH;
export GOROOT='/Users/grayson/.gimme/versions/go1.9.darwin.amd64';
export PATH="/Users/grayson/.gimme/versions/go1.9.darwin.amd64/bin:${PATH}";
go version >&2;

@dfawley dfawley merged commit 47d8591 into grpc:master Aug 29, 2017
@dfawley dfawley deleted the go19 branch August 29, 2017 23:29
menghanl pushed a commit to menghanl/grpc-go that referenced this pull request Aug 30, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants