Adding call options for PerRPCCredentials #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
reviewed
May 10, 2017
transport/http2_client.go
Outdated
| conn.Close() | ||
| } | ||
| }(conn) | ||
| var isSecure bool |
There was a problem hiding this comment.
group these two with
var(
...
)
transport/http2_client.go
Outdated
| callAuthData := make(map[string]string) | ||
| if callCreds := callHdr.Creds; callCreds != nil { | ||
| if !t.isSecure && callCreds.RequireTransportSecurity() { | ||
| return nil, streamErrorf(codes.Unauthenticated, "transport: cannot send secure credentials on an insecure channel") |
There was a problem hiding this comment.
s/channel/connection
The word channel is misleading in golang...
transport/http2_client.go
Outdated
| if !t.isSecure && callCreds.RequireTransportSecurity() { | ||
| return nil, streamErrorf(codes.Unauthenticated, "transport: cannot send secure credentials on an insecure channel") | ||
| } | ||
| data, err := callCreds.GetRequestMetadata(ctx) |
There was a problem hiding this comment.
GetRequestMetadata also takes parameter uri.
transport/http2_client.go
Outdated
| // Check if credentials.PerRPCCredentials were provided via call options. | ||
| // Note: if these credentials are provided both via dial options and call | ||
| // options, then both sets of credentials will be applied. | ||
| callAuthData := make(map[string]string) |
There was a problem hiding this comment.
Make authData a map[string][]string and reuse authData?
menghanl
approved these changes
May 11, 2017
MakMukhi
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.