Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move helpers in balancer/weightedroundrobin to appropriate files #6261

Open
zasweq opened this issue May 8, 2023 · 1 comment
Open

Move helpers in balancer/weightedroundrobin to appropriate files #6261

zasweq opened this issue May 8, 2023 · 1 comment
Assignees
@zasweq
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. fixit P2 Type: Bug

Comments

@zasweq
Copy link
Contributor

zasweq commented May 8, 2023

The helpers in balancer/weightedroundrobin are not related to the weightedroundrobin implementation. We should move them to a more appropriate place in the codebase.
@zasweq zasweq self-assigned this May 8, 2023
@zasweq zasweq mentioned this issue May 8, 2023
Merged
@arvindbr8
Copy link
Member

@zasweq the issue mentioned above seems to be merged. Is this a reactive from that PR?

@easwars easwars added the P2 label Jun 27, 2023
@zasweq zasweq added the fixit label Sep 19, 2023
@purnesh42H purnesh42H added the Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zasweq zasweq

Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. fixit P2 Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@easwars @purnesh42H @arvindbr8 @zasweq