Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-go-grpc: confusion between --go-grpc_out and --go-grpc_opt in README #5651

Open
ggratte opened this issue Sep 12, 2022 · 2 comments
Assignees
Labels
Area: Codegen Includes anything related to protoc-gen-go-grpc. fixit P3 Type: Documentation Documentation or examples

Comments

@ggratte
Copy link

ggratte commented Sep 12, 2022

--go-grpc_out=require_unimplemented_servers
should be
--go-grpc_opt=require_unimplemented_servers
https://github.com/grpc/grpc-go/blob/master/cmd/protoc-gen-go-grpc/README.md

@dfawley
Copy link
Member

dfawley commented Sep 12, 2022

--go-grpc_out is correct if you use :. at the end as documented.

So the documentation is correct. But maybe we should change this anyway to use --go-grpc_out=. --go-grpc_opt=[etc] because it isn't the first time people have reported being confused by it.

@dfawley dfawley added Type: Documentation Documentation or examples P3 and removed Type: Bug labels Sep 12, 2022
@dfawley dfawley changed the title There is a mistake in the documentation that will ruin the days for beginners :) protoc-gen-go-grpc: confusion between --go-grpc_out and --go-grpc_opt in README Sep 12, 2022
@dfawley dfawley added the fixit label Nov 28, 2022
@purnesh42H purnesh42H added the Area: Codegen Includes anything related to protoc-gen-go-grpc. label Sep 7, 2024
@hanut19
Copy link
Contributor

hanut19 commented Nov 5, 2024

@purnesh42H please assign this to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Codegen Includes anything related to protoc-gen-go-grpc. fixit P3 Type: Documentation Documentation or examples
Projects
None yet
Development

No branches or pull requests

4 participants