Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in non-major release #3726

Closed
gbbr opened this issue Jul 6, 2020 · 1 comment
Closed

Breaking change in non-major release #3726

gbbr opened this issue Jul 6, 2020 · 1 comment

Comments

@gbbr
Copy link

gbbr commented Jul 6, 2020

You have removed the naming package. A deprecated package (or method, function, type for that matter) means that it will be removed in the next major version, which means v2.0.0.

This in turn breaks google.golang.org/api which uses it. Now, it is no longer possible to use the latest grpc release along side this package.

Would you consider adding it back in a patch release? With this change you have technically broken semver.

@dfawley
Copy link
Member

dfawley commented Jul 6, 2020

Please see our published versioning policy. The package was clearly marked as experimental at GA, so it could be removed according to the policy.

@dfawley dfawley closed this as completed Jul 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants