Skip to content

Commit 829919d

Browse files
authored
xds client: Updated v3 type for http connection manager (#4137)
1 parent f4a20d2 commit 829919d

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

xds/internal/client/client_lds_test.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import (
3131
v3httppb "github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3"
3232
v3tlspb "github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3"
3333
"github.com/golang/protobuf/proto"
34+
"github.com/golang/protobuf/ptypes"
3435
anypb "github.com/golang/protobuf/ptypes/any"
3536
wrapperspb "github.com/golang/protobuf/ptypes/wrappers"
3637
"github.com/google/go-cmp/cmp"
@@ -87,14 +88,11 @@ func (s) TestUnmarshalListener_ClientSide(t *testing.T) {
8788
},
8889
},
8990
}
90-
mcm, _ := proto.Marshal(cm)
91+
mcm, _ := ptypes.MarshalAny(cm)
9192
lis := &v3listenerpb.Listener{
9293
Name: v3LDSTarget,
9394
ApiListener: &v3listenerpb.ApiListener{
94-
ApiListener: &anypb.Any{
95-
TypeUrl: version.V3HTTPConnManagerURL,
96-
Value: mcm,
97-
},
95+
ApiListener: mcm,
9896
},
9997
}
10098
mLis, _ := proto.Marshal(lis)

xds/internal/version/version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ const (
4545
V3RouteConfigURL = "type.googleapis.com/envoy.config.route.v3.RouteConfiguration"
4646
V3ClusterURL = "type.googleapis.com/envoy.config.cluster.v3.Cluster"
4747
V3EndpointsURL = "type.googleapis.com/envoy.config.endpoint.v3.ClusterLoadAssignment"
48-
V3HTTPConnManagerURL = "type.googleapis.com/envoy.config.filter.network.http_connection_manager.v3.HttpConnectionManager"
48+
V3HTTPConnManagerURL = "type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager"
4949
V3UpstreamTLSContextURL = "type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext"
5050
V3DownstreamTLSContextURL = "type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.DownstreamTlsContext"
5151
)

0 commit comments

Comments
 (0)