Skip to content

Commit 7f99944

Browse files
committed
Responded to Doug's comments
1 parent 883ee42 commit 7f99944

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

stats/opentelemetry/opentelemetry.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -74,16 +74,16 @@ type MetricsOptions struct {
7474
// MethodAttributeFilter is a function that determines whether to record the
7575
// method name of RPCs as an attribute, or to bucket into "other". Take care
7676
// to limit the values allowed, as allowing too many will increase
77-
// cardinality and could cause severe memory or performance problems. On
78-
// Client Side, to record the method name along with metric instead of
79-
// bucketing into "other pass a grpc.StaticMethodCallOption as a call option
80-
// into Invoke or NewStream.
77+
// cardinality and could cause severe memory or performance problems.
8178
//
82-
// This only applies for server side metrics.
79+
// This only applies for server-side metrics. For clients, to record the
80+
// method name in the attributes, pass grpc.StaticMethodCallOption to Invoke
81+
// or NewStream. Note that when using protobuf generated clients, this
82+
// CallOption is included automatically.
8383
MethodAttributeFilter func(string) bool
8484

85-
// OptionalLabels specifies a list of optional labels that will be included
86-
// on any metrics that have corresponding optional labels configured.
85+
// OptionalLabels specifies a list of optional labels to enable on any
86+
// metrics that support them.
8787
OptionalLabels []string
8888

8989
// pluginOption is used to get labels to attach to certain metrics, if set.

0 commit comments

Comments
 (0)