review feedback

coxley · coxley · commit 6deaf1eedac3 · 2024-08-29T19:10:00.000-04:00
diff --git a/server.go b/server.go
@@ -1359,6 +1359,7 @@ func (s *Server) processUnaryRPC(ctx context.Context, t transport.ServerTranspor
 		}
 		return err
 	}
+	defer d.Free()
 	if channelz.IsOn() {
 		t.IncrMsgRecv()
 	}
@@ -1391,8 +1392,6 @@ func (s *Server) processUnaryRPC(ctx context.Context, t transport.ServerTranspor
 	}
 	ctx = NewContextWithServerTransportStream(ctx, stream)
 	reply, appErr := md.Handler(info.serviceImpl, ctx, df, s.opts.unaryInt)
-	defer d.Free()
-
 	if appErr != nil {
 		appStatus, ok := status.FromError(appErr)
 		if !ok {

Original file line number	Diff line number	Diff line change
`@@ -1359,6 +1359,7 @@ func (s *Server) processUnaryRPC(ctx context.Context, t transport.ServerTranspor`
`1359`	`1359`	`}`
`1360`	`1360`	`return err`
`1361`	`1361`	`}`
	`1362`	`+ defer d.Free()`
`1362`	`1363`	`if channelz.IsOn() {`
`1363`	`1364`	`t.IncrMsgRecv()`
`1364`	`1365`	`}`
`@@ -1391,8 +1392,6 @@ func (s *Server) processUnaryRPC(ctx context.Context, t transport.ServerTranspor`
`1391`	`1392`	`}`
`1392`	`1393`	`ctx = NewContextWithServerTransportStream(ctx, stream)`
`1393`	`1394`	`reply, appErr := md.Handler(info.serviceImpl, ctx, df, s.opts.unaryInt)`
`1394`		`- defer d.Free()`
`1395`		`-`
`1396`	`1395`	`if appErr != nil {`
`1397`	`1396`	`appStatus, ok := status.FromError(appErr)`
`1398`	`1397`	`if !ok {`