Skip to content

Commit 25b60e3

Browse files
committed
rpc_util: rename NewSimpleSharedBufferPool to NewsimpleSharedBufferPool
1 parent 9be7889 commit 25b60e3

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

benchmark/benchmain/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,8 @@ func makeClient(bf stats.Features) (testgrpc.BenchmarkServiceClient, func()) {
331331
case recvBufferPoolNil:
332332
// Do nothing.
333333
case recvBufferPoolSimple:
334-
opts = append(opts, grpc.WithRecvBufferPool(grpc.NewSimpleSharedBufferPool()))
335-
sopts = append(sopts, grpc.RecvBufferPool(grpc.NewSimpleSharedBufferPool()))
334+
opts = append(opts, grpc.WithRecvBufferPool(grpc.NewsimpleSharedBufferPool()))
335+
sopts = append(sopts, grpc.RecvBufferPool(grpc.NewsimpleSharedBufferPool()))
336336
default:
337337
logger.Fatalf("Unknown shared recv buffer pool type: %v", bf.RecvBufferPool)
338338
}

dialoptions.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -663,7 +663,7 @@ func WithResolvers(rs ...resolver.Builder) DialOption {
663663
// on the application's workload, this could result in reduced memory allocation.
664664
//
665665
// If you are unsure about how to implement a memory pool but want to utilize one,
666-
// begin with grpc.NewSimpleSharedBufferPool.
666+
// begin with grpc.NewsimpleSharedBufferPool.
667667
//
668668
// Note: The shared buffer pool feature will not be active if any of the following
669669
// options are used: WithStatsHandler, EnableTracing, or binary logging. In such

server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ func NumStreamWorkers(numServerWorkers uint32) ServerOption {
559559
// on the application's workload, this could result in reduced memory allocation.
560560
//
561561
// If you are unsure about how to implement a memory pool but want to utilize one,
562-
// begin with grpc.NewSimpleSharedBufferPool.
562+
// begin with grpc.NewsimpleSharedBufferPool.
563563
//
564564
// Note: The shared buffer pool feature will not be active if any of the following
565565
// options are used: StatsHandler, EnableTracing, or binary logging. In such

shared_buffer_pool.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@ type SharedBufferPool interface {
3838
Put(*[]byte)
3939
}
4040

41-
// NewSimpleSharedBufferPool creates a new SimpleSharedBufferPool with buckets
41+
// NewsimpleSharedBufferPool creates a new simpleSharedBufferPool with buckets
4242
// of different sizes to optimize memory usage. This prevents the pool from
4343
// wasting large amounts of memory, even when handling messages of varying sizes.
4444
//
4545
// # Experimental
4646
//
4747
// Notice: This API is EXPERIMENTAL and may be changed or removed in a
4848
// later release.
49-
func NewSimpleSharedBufferPool() SharedBufferPool {
49+
func NewsimpleSharedBufferPool() SharedBufferPool {
5050
return &simpleSharedBufferPool{
5151
pools: [poolArraySize]simpleSharedBufferChildPool{
5252
newBytesPool(level0PoolMaxSize),

shared_buffer_pool_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import "testing"
2323
func (s) TestSharedBufferPool(t *testing.T) {
2424
pools := []SharedBufferPool{
2525
nopBufferPool{},
26-
NewSimpleSharedBufferPool(),
26+
NewsimpleSharedBufferPool(),
2727
}
2828

2929
lengths := []int{

0 commit comments

Comments
 (0)