-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: fix release builds #884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MUST NOT BE MERGED AS IS
I rebuilt the build environment image with go 1.12 which explains some of the other errors. |
037766f
to
bc73cb2
Compare
Gonna leave the updating of the build environment for another PR. |
Codecov Report
@@ Coverage Diff @@
## master #884 +/- ##
=======================================
Coverage 53.69% 53.69%
=======================================
Files 39 39
Lines 3926 3926
=======================================
Hits 2108 2108
Misses 1621 1621
Partials 197 197 Continue to review full report at Codecov.
|
bc73cb2
to
571982b
Compare
For some reason running "go mod vendor" edited the sum file. Lets make sure there are no more surprises by running it in CI as well.
299fc34
to
b5605b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good from very quick look.
One thing you could do to help test it before going 'live' is to first tag it with a semver prerelease tag like v1.8.1-pre1
, which means someone can use that as part of a go get github.com/grpc-ecosystem/grpc-gateway@v1.8.1-pre1
, but it won't yet be live for someone that does not use the prelease tag.
Excellent idea, I shall action that as soon as I've merged this. |
b5605b0
to
da7d0a3
Compare
da7d0a3
to
8481818
Compare
8481818
to
c1d71cf
Compare
* CI: fix release builds * Solve resty issue once and for all with sed magic
For some reason running "go mod vendor" edited the sum file.
Lets make sure there are no more surprises by running it in
CI as well.
Fixes #886