Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix release builds #884

Merged
merged 2 commits into from
Mar 1, 2019
Merged

CI: fix release builds #884

merged 2 commits into from
Mar 1, 2019

Conversation

johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst commented Mar 1, 2019

For some reason running "go mod vendor" edited the sum file.
Lets make sure there are no more surprises by running it in
CI as well.

Fixes #886

Copy link
Collaborator Author

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUST NOT BE MERGED AS IS

.circleci/config.yml Outdated Show resolved Hide resolved
@johanbrandhorst
Copy link
Collaborator Author

I rebuilt the build environment image with go 1.12 which explains some of the other errors.

@johanbrandhorst
Copy link
Collaborator Author

Gonna leave the updating of the build environment for another PR.

@codecov-io
Copy link

codecov-io commented Mar 1, 2019

Codecov Report

Merging #884 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #884   +/-   ##
=======================================
  Coverage   53.69%   53.69%           
=======================================
  Files          39       39           
  Lines        3926     3926           
=======================================
  Hits         2108     2108           
  Misses       1621     1621           
  Partials      197      197

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 920e58b...c1d71cf. Read the comment docs.

For some reason running "go mod vendor" edited the sum file.
Lets make sure there are no more surprises by running it in
CI as well.
@johanbrandhorst johanbrandhorst force-pushed the fix-release-builds branch 2 times, most recently from 299fc34 to b5605b0 Compare March 1, 2019 23:04
Copy link

@thepudds thepudds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from very quick look.

One thing you could do to help test it before going 'live' is to first tag it with a semver prerelease tag like v1.8.1-pre1, which means someone can use that as part of a go get github.com/grpc-ecosystem/grpc-gateway@v1.8.1-pre1, but it won't yet be live for someone that does not use the prelease tag.

@johanbrandhorst
Copy link
Collaborator Author

This looks good from very quick look.

One thing you could do to help test it before going 'live' is to first tag it with a semver prerelease tag like v1.8.1-pre1, which means someone can use that as part of a go get github.com/grpc-ecosystem/grpc-gateway@v1.8.1-pre1, but it won't yet be live for someone that does not use the prelease tag.

Excellent idea, I shall action that as soon as I've merged this.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@johanbrandhorst johanbrandhorst merged commit 4ce2f87 into master Mar 1, 2019
@johanbrandhorst johanbrandhorst deleted the fix-release-builds branch March 1, 2019 23:47
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
* CI: fix release builds

* Solve resty issue once and for all with sed magic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants