improved customizingyourgateway.md

[iamrajiv]

typo fix and removed grammatical mistakes in docs/_docs/customizingyourgateway.md

[johanbrandhorst]

Thanks for this proposal! However, it is idiomatic in Go to use tabs for indentation (gofmt uses it: https://golang.org/cmd/gofmt/), so I'm not sure using spaces in the snippets is appropriate. I noticed some of the lines are mixing spaces and tabs though, so maybe you could change all the snippets to use tabs consistently?

[iamrajiv]

thank you for feedback @johanbrandhorst I have removed tabs and followed https://golang.org/cmd/gofmt/ please take a look

[codecov-io]

Codecov Report

Merging #1359 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1359   +/-   ##
=======================================
  Coverage   54.14%   54.14%           
=======================================
  Files          42       42           
  Lines        4375     4375           
=======================================
  Hits         2369     2369           
  Misses       1750     1750           
  Partials      256      256           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c860e27...0292c1e. Read the comment docs.

[johanbrandhorst]

thank you for feedback @johanbrandhorst I have removed tabs and followed https://golang.org/cmd/gofmt/ please take a look

Sorry for the confusion; what I mean is that we should use tabs in all the Go snippets, as gofmt does.

[iamrajiv]

I got it means previous changes what I made was correct and I should make other files to https://golang.org/cmd/gofmt/ is that right? @johanbrandhorst

[johanbrandhorst]

I got it means previous changes what I made was correct and I should make other files to https://golang.org/cmd/gofmt/ is that right? @johanbrandhorst

The first change you made, seemed to me to introduce spaces in place of tabs. We don't want to use spaces in the Go snippets, because idiomatic Go code uses tabs.

[codecov-commenter]

Codecov Report

Merging #1359 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1359   +/-   ##
=======================================
  Coverage   54.14%   54.14%           
=======================================
  Files          42       42           
  Lines        4375     4375           
=======================================
  Hits         2369     2369           
  Misses       1750     1750           
  Partials      256      256           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c860e27...c8e696c. Read the comment docs.

[johanbrandhorst]

Maybe just leave the snippets for now and focus on the prose? These are really great changes.

[iamrajiv]

@johanbrandhorst can you review my last changes?

[iamrajiv]

@johanbrandhorst can you review the changes?

[johanbrandhorst]

Thanks, this looks great!

[johanbrandhorst]

Thanks for your contribution! Could you please cherry pick this against the v2 branch?