-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix customizing your gateway documentation CustomMatcher example #1142
Fix customizing your gateway documentation CustomMatcher example #1142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The CI build isn't working 🤔 |
Could you try force pushing to the branch again? |
It seems to not took any effect:
And it is not show up in circleci https://circleci.com/gh/grpc-ecosystem/grpc-gateway |
Seems like closing and reopening did it |
Codecov Report
@@ Coverage Diff @@
## master #1142 +/- ##
=======================================
Coverage 53.79% 53.79%
=======================================
Files 42 42
Lines 4207 4207
=======================================
Hits 2263 2263
Misses 1696 1696
Partials 248 248 Continue to review full report at Codecov.
|
…pc-ecosystem#1142) * Fix customizing your gateway documentation CustomMatcher example * Add more documentation about mapping from HTTP request headers to gRPC client metadata
…pc-ecosystem#1142) * Fix customizing your gateway documentation CustomMatcher example * Add more documentation about mapping from HTTP request headers to gRPC client metadata
Fix customizing your gateway documentation CustomMatcher example and add more documentation about mapping from HTTP request headers to gRPC client metadata.