Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix customizing your gateway documentation CustomMatcher example #1142

Merged
merged 2 commits into from
Feb 29, 2020

Conversation

wiliamsouza
Copy link
Contributor

Fix customizing your gateway documentation CustomMatcher example and add more documentation about mapping from HTTP request headers to gRPC client metadata.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johanbrandhorst
Copy link
Collaborator

The CI build isn't working 🤔

@johanbrandhorst
Copy link
Collaborator

Could you try force pushing to the branch again?

@wiliamsouza
Copy link
Contributor Author

Could you try force pushing to the branch again?

It seems to not took any effect:

~/.../grpc-gateway$ git push -f origin header-matcher-doc 
Everything up-to-date

And it is not show up in circleci https://circleci.com/gh/grpc-ecosystem/grpc-gateway

@johanbrandhorst
Copy link
Collaborator

Seems like closing and reopening did it

@codecov-io
Copy link

Codecov Report

Merging #1142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1142   +/-   ##
=======================================
  Coverage   53.79%   53.79%           
=======================================
  Files          42       42           
  Lines        4207     4207           
=======================================
  Hits         2263     2263           
  Misses       1696     1696           
  Partials      248      248

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000dde5...94f8d0f. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 9aff355 into grpc-ecosystem:master Feb 29, 2020
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
…pc-ecosystem#1142)

* Fix customizing your gateway documentation CustomMatcher example

* Add more documentation about mapping from HTTP request headers to gRPC client metadata
pull bot pushed a commit to BuildingRobotics/grpc-gateway that referenced this pull request Apr 29, 2020
…pc-ecosystem#1142)

* Fix customizing your gateway documentation CustomMatcher example

* Add more documentation about mapping from HTTP request headers to gRPC client metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants