Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly load rules_proto rules #1102

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Explicitly load rules_proto rules #1102

merged 2 commits into from
Dec 20, 2019

Conversation

achew22
Copy link
Collaborator

@achew22 achew22 commented Dec 16, 2019

Fixes: #1101

@johanbrandhorst
Copy link
Collaborator

johanbrandhorst commented Dec 17, 2019 •
edited
Loading 

ERROR: error loading package 'internal': Label '//third_party/bazel_rules/rules_proto/proto:defs.bzl' is invalid because 'third_party/bazel_rules/rules_proto/proto' is not a package; perhaps you meant to put the colon here: '//:third_party/bazel_rules/rules_proto/proto/defs.bzl'?

@johanbrandhorst johanbrandhorst self-requested a review December 17, 2019 09:43
johanbrandhorst
johanbrandhorst requested changes Dec 17, 2019
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the failure is, but CI is failing.

@achew22
Copy link
Collaborator Author

achew22 commented Dec 17, 2019

Sorry @johanbrandhorst I started this at work but then had to do work things. Will handle "soon"

@drigz
Copy link
Contributor

drigz commented Dec 18, 2019

IIUC it's not possible to fix this as a rules_go update is not available. I pinged the reporter: googlecloudrobotics/core#24 (comment)

@achew22
Copy link
Collaborator Author

achew22 commented Dec 20, 2019

@drigz, I don't think we depend on the codepath in rules_go that's also needs to be upgraded.

@johanbrandhorst PTAL (sorry it's all greek to you)

@johanbrandhorst johanbrandhorst merged commit e8db07a into grpc-ecosystem:master Dec 20, 2019
@achew22 achew22 deleted the rules_proto branch October 27, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grpc-gateway is incompatible with --incompatible_load_proto_rules_from_bzl
4 participants
@achew22 @johanbrandhorst @drigz @googlebot