protovalidate: avoid pointer comparisons #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akshay Shah <akshay@akshayshah.org>
When deciding whether the user has bypassed validation for a message, we should compare the message's fully-qualified name rather than doing a fragile pointer comparison. Along the way, this commit removes some puzzling and unused code to plumb a context through the wrappedServerStream. Signed-off-by: Akshay Shah <akshay@akshayshah.org>
For completeness, the tests should assert whether the server implementation is actually called or not. Signed-off-by: Akshay Shah <akshay@akshayshah.org>
Signed-off-by: Akshay Shah <akshay@akshayshah.org>
akshayjshah
commented
May 25, 2024
| type wrappedServerStream struct { | ||
| grpc.ServerStream | ||
| // wrappedContext is the wrapper's own Context. You can assign it. | ||
| wrappedContext context.Context |
There was a problem hiding this comment.
This field wasn't used anywhere, so I deleted it. 🤷🏽♂️
johanbrandhorst
requested changes
May 26, 2024
Signed-off-by: Akshay Shah <akshay@akshayshah.org>
johanbrandhorst
approved these changes
May 27, 2024
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WithIgnoreMessagesto avoid fragile pointercomparisons. Instead, we match messages using their fully-qualified names.
implementation should be called.
Verification
The unit tests should fully exercise the changes made.