Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for connect go #622

Open
acbeni opened this issue Aug 26, 2023 · 5 comments
Open

Support for connect go #622

acbeni opened this issue Aug 26, 2023 · 5 comments

Comments

@acbeni
Copy link

acbeni commented Aug 26, 2023

While working with another code generator ,connect go i missed the rich middleware env provided by this lib, and had the idea of forking this repo to modify the code to be suitable for the Interceptor interface in connect go.

But before that i wanted to ask if its healthier to refactor the common parts, and try to make this library compatible with both interfaces (the second being the grpc interceptor from grpc go) in which case i can contribute with PRs. or you would rather keep focus on grpc go and leave forks for other implementations.

Thanks in advance 🙏

@johanbrandhorst
Copy link
Collaborator

I think it'd be great to have some way to adapt the middleware in this repo for use with Connect. The library is already pretty dynamic so it might be possible to write a simple adapter.

CC @bwplotka @akshayjshah

@bwplotka
Copy link
Collaborator

bwplotka commented Aug 28, 2023 via email

@acbeni
Copy link
Author

acbeni commented Aug 29, 2023

Thank you for your encouraging replies, one question do you want me to do a POC on a fork and post link here, or how do you want me to proceed?

@johanbrandhorst
Copy link
Collaborator

Nah just open a PR and we can take it from there

@acbeni
Copy link
Author

acbeni commented Aug 29, 2023

Sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants