Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cla bot doesn't work well #855

Open
Altonss opened this issue May 18, 2023 · 5 comments
Open

Cla bot doesn't work well #855

Altonss opened this issue May 18, 2023 · 5 comments
Labels
enhancement 🏗️ A functional improvement.

Comments

@Altonss
Copy link
Collaborator

Altonss commented May 18, 2023

Describe the bug
The Cla bot doesn't detect when users sign the CLA in the PR, this creates huge overhead as we (ping @pt2121) first need a maintainer to commit the username to the file outside of the PR.

Couldn't there be a more straight forward way (automatic), to accept user contributions? I feel like this is slowing down the development...

cc @grote @ialokim

@Altonss Altonss added the bug 🐞 A functional defect or unexpected behavior. label May 18, 2023
@ialokim
Copy link
Collaborator

ialokim commented May 18, 2023

We had this discussion before at some point, the bot indeed just looks at the file on the master branch. But it does not block merging itself, so if the PR authors add themselves to the file as part of the PR, it will be on master after merging. The only annoying part is that the bot keeps posting the same message, I agree with that.

That said, if you find any other Github bot which works in a better way, feel free to propose it here!

@Altonss
Copy link
Collaborator Author

Altonss commented May 18, 2023

I will try to search for it, thanks!

@grote
Copy link
Owner

grote commented May 23, 2023

You can also just disable it and remove the CLA requirement, if you want. Then the app stays with its current license forever.

@pt2121
Copy link
Collaborator

pt2121 commented Jun 24, 2023

cla-assistant-lite looks promising. Or, let's just remove it?

@Altonss Altonss added enhancement 🏗️ A functional improvement. and removed bug 🐞 A functional defect or unexpected behavior. labels Dec 6, 2023
@Altonss
Copy link
Collaborator Author

Altonss commented May 13, 2024

Why not just remove it? This article explains why CLAs can be questionable: https://drewdevault.com/2023/07/04/Dont-sign-a-CLA-2.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🏗️ A functional improvement.
Projects
None yet
Development

No branches or pull requests

4 participants