-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cla bot doesn't work well #855
Comments
We had this discussion before at some point, the bot indeed just looks at the file on the master branch. But it does not block merging itself, so if the PR authors add themselves to the file as part of the PR, it will be on master after merging. The only annoying part is that the bot keeps posting the same message, I agree with that. That said, if you find any other Github bot which works in a better way, feel free to propose it here! |
I will try to search for it, thanks! |
You can also just disable it and remove the CLA requirement, if you want. Then the app stays with its current license forever. |
cla-assistant-lite looks promising. Or, let's just remove it? |
Why not just remove it? This article explains why CLAs can be questionable: https://drewdevault.com/2023/07/04/Dont-sign-a-CLA-2.html |
Describe the bug
The Cla bot doesn't detect when users sign the CLA in the PR, this creates huge overhead as we (ping @pt2121) first need a maintainer to commit the username to the file outside of the PR.
Couldn't there be a more straight forward way (automatic), to accept user contributions? I feel like this is slowing down the development...
cc @grote @ialokim
The text was updated successfully, but these errors were encountered: