From 8414ba2e1a56efcc1bd5012fc508e8f93d277b31 Mon Sep 17 00:00:00 2001 From: Torsten Grote Date: Tue, 30 Apr 2019 14:56:22 -0300 Subject: [PATCH] Indicate when connections are cancelled or impossible Closes #598 --- .../grobox/transportr/trips/search/TripViewHolder.kt | 10 ++++++++-- app/src/main/res/values/strings.xml | 1 + app/src/main/res/xml/changelog_master.xml | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/de/grobox/transportr/trips/search/TripViewHolder.kt b/app/src/main/java/de/grobox/transportr/trips/search/TripViewHolder.kt index b99eada21..a8da61df7 100644 --- a/app/src/main/java/de/grobox/transportr/trips/search/TripViewHolder.kt +++ b/app/src/main/java/de/grobox/transportr/trips/search/TripViewHolder.kt @@ -46,8 +46,13 @@ internal class TripViewHolder(private val v: View) : BaseViewHolder(v) { private val duration: TextView = v.findViewById(R.id.duration) fun bind(trip: Trip, listener: OnTripClickListener) { - // Relative Departure Time - setRelativeDepartureTime(fromTimeRel, trip.firstDepartureTime) + if (trip.isTravelable) { + // Relative Departure Time + setRelativeDepartureTime(fromTimeRel, trip.firstDepartureTime) + } else { + fromTimeRel.setText(R.string.trip_not_travelable) + fromTimeRel.visibility = VISIBLE + } // Departure Time and Delay val firstLeg = trip.legs[0] @@ -96,6 +101,7 @@ internal class TripViewHolder(private val v: View) : BaseViewHolder(v) { } private fun Trip.hasProblem(): Boolean { + if (!isTravelable) return true for (leg in legs) { if (leg !is Public) continue if (!isNullOrEmpty(leg.message)) return true diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 2ffe1b21c..99c42d6bf 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -156,6 +156,7 @@ and always knows where you are to not miss where to get off the bus. The data provider is currently down :(\nPlease try again later. If you want to report this error, please report it to public-transport-enabler directly and attach a screenshot. There might be a problem with this connection. + Impossible or cancelled Try Again diff --git a/app/src/main/res/xml/changelog_master.xml b/app/src/main/res/xml/changelog_master.xml index 08efa6e11..e466da8e8 100644 --- a/app/src/main/res/xml/changelog_master.xml +++ b/app/src/main/res/xml/changelog_master.xml @@ -2,6 +2,7 @@ + Indicate when connections are cancelled or impossible Fix bug where search results would sometimes not appear New translation: Ukrainian (Thanks Paul!)