[GAIA-21588] Create a function to convert v2prime result into dataframe #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is a REST API, not a pandas endpoint.
We should support standards like CSV or JSON.
…On Wed, May 10, 2023 at 10:11 PM Muzi Gao ***@***.***> wrote:
See this discussion:
https://gro-intelligence.slack.com/archives/CUVUBHQE9/p1683578154127809?thread_ts=1683568514.990159&cid=CUVUBHQE9
I'm still debating whether or not we want to make dataframe as the default
response format for get_data_points, but now I'm making a separate function:
- converted timestamp into date (so it's human readable)
- merge series_description into combined dataframe
------------------------------
You can view, comment on, or merge this pull request online at:
#379
Commit Summary
- 255ba81
<255ba81>
update docstring
- d7e5c5b
<d7e5c5b>
new df function
- 960b8f1
<960b8f1>
add comments
File Changes
(1 file <https://github.com/gro-intelligence/api-client/pull/379/files>)
- *M* groclient/experimental.py
<https://github.com/gro-intelligence/api-client/pull/379/files#diff-a9102b652783726e7c400ed0a46b6c87f8c0e22a2d3ce666dbba882d2e94e211>
(83)
Patch Links:
- https://github.com/gro-intelligence/api-client/pull/379.patch
- https://github.com/gro-intelligence/api-client/pull/379.diff
—
Reply to this email directly, view it on GitHub
<#379>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACW4Q7GLLKSV4DMZBF6PDTXFRDEZANCNFSM6AAAAAAX5OS7V4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
The contents of this email message and any attachments are intended solely
for the addressee(s) and may contain confidential and/or privileged
information and may be legally protected from disclosure. If you are not
the intended recipient of this message or their agent, or if this message
has been addressed to you in error, please immediately alert the sender by
reply email and then delete this message and any attachments. If you are
not the intended recipient, you are hereby notified that any use,
dissemination, copying, or storage of this message or its attachments is
strictly prohibited.
|
Contributor
Author
|
elia-gro
approved these changes
Jun 2, 2023
elia-gro
left a comment
elia-gro
left a comment
There was a problem hiding this comment.
LGTM on the output and conversion of pandas DataFrame
elia-gro
reviewed
Jun 2, 2023
| } | ||
| }, | ||
| { | ||
| "data_points": [ |
There was a problem hiding this comment.
Can we have more than one data points?
Contributor
Author
There was a problem hiding this comment.
data_points is the list of data points per series, yes you can have multiple series in response, but each series dic should only have one data_points attribute
groclient/experimental_test.py
Outdated
| mock_get_data_points.return_value = mock_v2_prime_data_response.copy() | ||
| df = self.client.get_data_points_df(**mock_v2_prime_data_request) | ||
|
|
||
| self.assertEqual(df.iloc[0]["start_timestamp"], date(2023, 5, 1)) |
Contributor
There was a problem hiding this comment.
Can use pandas.testing assert_frames_equal, and init expected df directly so that it's easier to read:
https://github.com/gro-intelligence/gro/blob/main/infrastructure/derived-compute/historical_stats/test_generate_10y_avg.py#L28
Contributor
Author
There was a problem hiding this comment.
ha that's a good idea
groclient/experimental.py
Outdated
| return data_stream_list | ||
|
|
||
|
|
||
| def get_data_points_df(self, **selections): |
Contributor
There was a problem hiding this comment.
Add type annotations.
John-Desmond
approved these changes
Jun 12, 2023
Contributor
John-Desmond
left a comment
John-Desmond
left a comment
There was a problem hiding this comment.
minor updates requested, otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this discussion: https://gro-intelligence.slack.com/archives/CUVUBHQE9/p1683578154127809?thread_ts=1683568514.990159&cid=CUVUBHQE9
I'm still debating whether or not we want to make dataframe as the default response format for get_data_points, but now I'm making a separate function: