Skip to content

Support Laravel 8 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Support Laravel 8 #145

merged 2 commits into from
Sep 21, 2020

Conversation

georgeboot
Copy link
Contributor

@georgeboot georgeboot commented Sep 4, 2020

This contains breaking changes (QueryBuilder::cleanBindings is now public), so needs to be released as a new major version (4.0).

@ngunyimacharia
Copy link

Hope this gets merged soon

@patrickomeara
Copy link

I can confirm this is working with Laravel 8. I am using the fork in production.

@grimzy grimzy linked an issue Sep 20, 2020 that may be closed by this pull request
@amdadulhoque
Copy link

It should be merge. It's working perfectly with Laravel-8

@grimzy
Copy link
Owner

grimzy commented Sep 20, 2020

Great, thank you! I'll take a look today.

Also, I wish the build wasn't so flaky. We have to see why the build is failing and do the appropriate changes.

Additionally, need to update the readme to reflect the new version.

@grimzy grimzy changed the base branch from master to laravel-8 September 20, 2020 19:50
@grimzy grimzy changed the base branch from laravel-8 to master September 20, 2020 20:18
@grimzy grimzy changed the base branch from master to v4 September 20, 2020 20:23
@grimzy grimzy merged commit a6a238f into grimzy:v4 Sep 21, 2020
@georgeboot georgeboot deleted the laravel-8 branch September 21, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composer dependency problem with Laravel 8
5 participants