fix token positions #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 69.86% 69.86%
=======================================
Files 64 64
Lines 8562 8562
Branches 2546 2546
=======================================
Hits 5982 5982
Misses 784 784
Partials 1796 1796
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
awvwgk
approved these changes
Mar 7, 2023
Member
awvwgk
left a comment
awvwgk
left a comment
There was a problem hiding this comment.
Good catch. Could we add a regression test for this as well?
MtoLStoN
approved these changes
Mar 7, 2023
Contributor
MtoLStoN
left a comment
MtoLStoN
left a comment
There was a problem hiding this comment.
Perfect, thank you, this should also fix grimme-lab/xtb#773.
Member
Author
I added new checks for this but accidentally pushed it to the central repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix the EIn format reader