Skip to content

Commit fd29af7

Browse files
committed
Update README.md
1 parent 287f21e commit fd29af7

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

README.md

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,26 @@ SELECT binary_quantize('[0,0.1,-0.2,-0.3,0.4,0.5,0.6,-0.7,0.8,-0.9,1]'::VECTOR);
6363

6464
**TODO**
6565

66-
Query Operators https://github.com/pgvector/pgvector/tree/master?tab=readme-ov-file#querying
66+
Add more types - halfvec, sparse vectors
67+
Query Operators - add more
68+
https://github.com/pgvector/pgvector/tree/master?tab=readme-ov-file#querying
6769

68-
There are problems extending an existing grammar through more than one level of inheritance. This would require fixes to
69-
https://github.com/sqldelight/Grammar-Kit-Composer - Such that, when adding to an existing type (e.g. data type) concatenation of PostgreSql types is required
70+
Extending an existing grammar through more than one level of inheritance isn't supported by grammar generator -
71+
This would require fixes to https://github.com/sqldelight/Grammar-Kit-Composer - work around is to override manually e.g.
72+
73+
```kotlin
74+
PostgreSqlParserUtil.type_name = Parser { psiBuilder, i ->
75+
type_name?.parse(psiBuilder, i) ?: PgvectorParser.type_name_real(psiBuilder, i)
76+
|| PostgreSqlParser.type_name_real(psiBuilder, i)
77+
}
78+
```
7079

7180
SqlDelight needs this fix https://github.com/sqldelight/sqldelight/pull/5625 for the module resolver to be the first
7281

73-
PostgreSqlTypeResolver needs to be (open) inheritable rather than use delegation e.g. override `definitionType` expects to be called
82+
PostgreSqlTypeResolver needs to be (open) inheritable rather than use delegation e.g.
83+
override `definitionType` method expects to be called via inheritance
84+
85+
Use Jdbc types https://github.com/pgvector/pgvector-java either directly in type resolver or using SqlDelight type adapters
7486

7587
```shell
7688
createdb vector &&

0 commit comments

Comments
 (0)