Change isxdigit to HexDigit in bignum.h

jamescowens · jamescowens · commit 6dbaf491ac84 · 2021-08-08T13:18:47.000-04:00
diff --git a/src/bignum.h b/src/bignum.h
@@ -369,12 +369,11 @@ class CBigNum : public CBigNumBase
             psz++;
 
         // hex string to bignum
-        static const signed char phexdigit[256] = { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, 0,1,2,3,4,5,6,7,8,9,0,0,0,0,0,0, 0,0xa,0xb,0xc,0xd,0xe,0xf,0,0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, 0,0xa,0xb,0xc,0xd,0xe,0xf,0,0,0,0,0,0,0,0,0 };
         *this = 0;
-        while (isxdigit(*psz))
+        while (HexDigit(*psz) >= 0)
         {
             *this <<= 4;
-            int n = phexdigit[(unsigned char)*psz++];
+            int n = HexDigit((unsigned char)*psz++);
             *this += n;
         }
         if (fNegative)

Original file line number	Diff line number	Diff line change
`@@ -369,12 +369,11 @@ class CBigNum : public CBigNumBase`
`369`	`369`	`psz++;`
`370`	`370`
`371`	`371`	`// hex string to bignum`
`372`		`- static const signed char phexdigit[256] = { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, 0,1,2,3,4,5,6,7,8,9,0,0,0,0,0,0, 0,0xa,0xb,0xc,0xd,0xe,0xf,0,0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, 0,0xa,0xb,0xc,0xd,0xe,0xf,0,0,0,0,0,0,0,0,0 };`
`373`	`372`	`*this = 0;`
`374`		`- while (isxdigit(*psz))`
	`373`	`+ while (HexDigit(*psz) >= 0)`
`375`	`374`	`{`
`376`	`375`	`*this <<= 4;`
`377`		`- int n = phexdigit[(unsigned char)*psz++];`
	`376`	`+ int n = HexDigit((unsigned char)*psz++);`
`378`	`377`	`*this += n;`
`379`	`378`	`}`
`380`	`379`	`if (fNegative)`