Skip to content

support text shadow #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Nov 5, 2021
Merged

support text shadow #55

merged 26 commits into from
Nov 5, 2021

Conversation

You-J
Copy link
Collaborator

@You-J You-J commented Oct 19, 2021 •
edited
Loading

in text style

  • css
  • flutter

css
Screen Shot 2021-11-06 at 2 43 56 AM

flutter
Screen Shot 2021-11-06 at 3 03 39 AM

css(has blur) link
Screen Shot 2021-11-06 at 5 19 22 AM

@vercel
Copy link

vercel bot commented Oct 19, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/grida/designto-codes/4S4dYBR1rhf4QGZnPigLKMnwPBj4
✅ Preview: https://designto-codes-git-support-text-shadow-grida.vercel.app

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ softmarshmallow
❌ You-J
You have signed the CLA already but the status is still pending? Let us recheck it.

@You-J You-J mentioned this pull request Oct 21, 2021
Merged
@You-J You-J marked this pull request as draft November 5, 2021 14:09
@You-J You-J mentioned this pull request Nov 5, 2021
Merged
@You-J You-J force-pushed the support-text-shadow branch from 43662aa to 79254c4 Compare November 5, 2021 15:10
@You-J You-J force-pushed the support-text-shadow branch from 075ecf5 to 79254c4 Compare November 5, 2021 15:32
@You-J You-J marked this pull request as ready for review November 5, 2021 15:32
@You-J You-J marked this pull request as draft November 5, 2021 15:33
@You-J You-J marked this pull request as ready for review November 5, 2021 15:47
softmarshmallow
softmarshmallow requested changes Nov 5, 2021
View reviewed changes
packages/designto-flutter/dart-ui/dart-ui-shadow.ts
import { TextShadowManifest } from "@reflect-ui/core";

export function shadow(
shadows: ReadonlyArray<TextShadowManifest>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convention not matching. is it correct that Shadow exists under dartui on official flutter docs?

Copy link
Collaborator Author

@You-J You-J Nov 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is. https://api.flutter.dev/flutter/dart-ui/Shadow-class.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. still the name and input type does not match intuitively, please add the link - https://api.flutter.dev/flutter/dart-ui/Shadow-class.html to jsdoc for shadow func

@You-J You-J force-pushed the support-text-shadow branch from 17869e4 to 875e42f Compare November 5, 2021 21:07
@softmarshmallow softmarshmallow merged commit da1ad5e into main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softmarshmallow softmarshmallow softmarshmallow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@You-J @CLAassistant @softmarshmallow