Sync with upstream #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some charging points send -1 there if the value is unknown. Definitely unexpected, but I actually can't find anything in the spec that excplicitly says that the value has to be positive (although it's reasonable to expect it from a meter reading). In any case, the spec explicitly says that the CS shouldn't reject a StopTransaction even if sanity checks fail, and this validation prevents the ocpp-go user from deciding for themselves.
This fixes sending messages to the client by newClientHandler function.
Signed-off-by: Lorenzo Donini <lorenzo.donini90@gmail.com>
- improve tests - improve stopped channel Signed-off-by: Lorenzo Donini <lorenzo.donini90@gmail.com>
- invoke respective setters for cancellation callbacks in ocpp 1.6 and 2.0.1 Signed-off-by: Lorenzo Donini <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
- updates 1.6 examples with verbose logs Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
dammarco
reviewed
Mar 25, 2022
Comment on lines
-43
to
+44
| MeterStop int `json:"meterStop" validate:"gte=0"` | ||
| MeterStop int `json:"meterStop"` |
There was a problem hiding this comment.
weird... we already had this change? 🤔
Comment on lines
-11
to
+12
| V2Subprotocol = "ocpp2.0.1" | ||
| V201Subprotocol = "ocpp2.0.1.1" | ||
| V2Subprotocol = "ocpp2.0" | ||
| V201Subprotocol = "ocpp2.0.1" |
| server.AddSupportedSubprotocol(types.V2Subprotocol) | ||
| server.AddSupportedSubprotocol(types.V201Subprotocol) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.