[0.5.1][hotfix] Add arbitrum to network list coinbase#242

[0.5.1][hotfix] Add arbitrum to network list

Author: jazz-cb

CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Unreleased 
 
+## [0.5.1] - 2024-09-12
+
+### Fixed
+- Fixed a bug that blocked arbitrum mainnet wallets from being created
+
 ## [0.5.0] - 2024-09-11
 
 - Add Arbitrum-Mainnet support for Native transfers.

jest.config.js

@@ -10,10 +10,10 @@ module.exports = {
   maxWorkers: 1,
   coverageThreshold: {
     "./src/coinbase/**": {
-      branches: 78,
+      branches: 77,
       functions: 90,
       statements: 85,
-      lines: 88,
+      lines: 87,
     },
   },
 };

package.json

@@ -4,7 +4,7 @@
   "license": "ISC",
   "description": "Coinbase Platform SDK",
   "repository": "https://github.com/coinbase/coinbase-sdk-nodejs",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "scripts": {

src/coinbase/wallet.ts

@@ -913,14 +913,7 @@ export class Wallet {
     if (!this.master) {
       throw new Error("Cannot derive key for Wallet without seed loaded");
     }
-    const [networkPrefix] = this.model.network_id.split("-");
-    /**
-     * TODO: Push this logic to the backend.
-     * TODO: Add unit tests for `#createAddress`.
-     */
-    if (!["base", "ethereum", "polygon"].includes(networkPrefix)) {
-      throw new Error(`Unsupported network ID: ${this.model.network_id}`);
-    }
+
     const derivedKey = this.master?.derive(this.addressPathPrefix + `/${index}`);
     if (!derivedKey?.privateKey) {
       throw new Error("Failed to derive key");

src/tests/wallet_test.ts

@@ -870,20 +870,6 @@ describe("Wallet Class", () => {
       expect(() => newWallet.setSeed(``)).toThrow(ArgumentError);
       expect(() => newWallet.setSeed(`invalid-seed`)).toThrow(ArgumentError);
     });
-
-    it("should raise an error when creating a wallet with an invalid network", async () => {
-      const newWallet = Wallet.init(
-        {
-          ...walletModel,
-          network_id: "invalid_network_id",
-        },
-        "",
-      );
-      newWallet.setSeed(existingSeed);
-      await expect(newWallet.createAddress()).rejects.toThrow(
-        "Unsupported network ID: invalid_network_id",
-      );
-    });
   });
 
   describe("#export", () => {