Skip to content

Commit 6c6c1fc

Browse files
Jeff Johnsonmasahir0y
Jeff Johnson
authored andcommitted
modpost: require a MODULE_DESCRIPTION()
Since commit 1fffe7a ("script: modpost: emit a warning when the description is missing"), a module without a MODULE_DESCRIPTION() has resulted in a warning with make W=1. Since that time, all known instances of this issue have been fixed. Therefore, now make it an error if a MODULE_DESCRIPTION() is not present. Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
1 parent cacd22c commit 6c6c1fc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

scripts/mod/modpost.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1602,8 +1602,8 @@ static void read_symbols(const char *modname)
16021602
namespace);
16031603
}
16041604

1605-
if (extra_warn && !get_modinfo(&info, "description"))
1606-
warn("missing MODULE_DESCRIPTION() in %s\n", modname);
1605+
if (!get_modinfo(&info, "description"))
1606+
error("missing MODULE_DESCRIPTION() in %s\n", modname);
16071607
}
16081608

16091609
for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {

0 commit comments

Comments
 (0)