Skip to content

Commit 28072a5

Browse files
g-papegitster
authored andcommitted
Don't cache DESTDIR in perl/perl.mak.
DESTDIR is supposed to be overridden on 'make install' after doing 'make'. Have the automatically generated perl/perl.mak not cache the value of DESTDIR to support that for the perl/ subdirectory also. Signed-off-by: Gerrit Pape <pape@smarden.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 923db42 commit 28072a5

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1025,7 +1025,7 @@ install: all
10251025
$(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexecdir_SQ)'
10261026
$(INSTALL) git$X '$(DESTDIR_SQ)$(bindir_SQ)'
10271027
$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install
1028-
$(MAKE) -C perl prefix='$(prefix_SQ)' install
1028+
$(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install
10291029
ifndef NO_TCLTK
10301030
$(MAKE) -C gitk-git install
10311031
$(MAKE) -C git-gui install

perl/Makefile.PL

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@ if ($@ || $Error::VERSION < 0.15009) {
1717
$pm{'private-Error.pm'} = '$(INST_LIBDIR)/Error.pm';
1818
}
1919

20-
my %extra;
21-
$extra{DESTDIR} = $ENV{DESTDIR} if $ENV{DESTDIR};
22-
2320
# redirect stdout, otherwise the message "Writing perl.mak for Git"
2421
# disrupts the output for the target 'instlibdir'
2522
open STDOUT, ">&STDERR";
@@ -29,6 +26,5 @@ WriteMakefile(
2926
VERSION_FROM => 'Git.pm',
3027
PM => \%pm,
3128
MAKEFILE => 'perl.mak',
32-
INSTALLSITEMAN3DIR => '$(SITEPREFIX)/share/man/man3',
33-
%extra
29+
INSTALLSITEMAN3DIR => '$(SITEPREFIX)/share/man/man3'
3430
);

0 commit comments

Comments
 (0)