Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Merging hackrf_sweeper into libhackrf #1486

Open
subreption-research opened this issue Sep 30, 2024 · 1 comment
Open

RFC: Merging hackrf_sweeper into libhackrf #1486

subreption-research opened this issue Sep 30, 2024 · 1 comment
Labels
enhancement potential new feature

Comments

@subreption-research
Copy link

What feature would you like to see and why?

We have recently released hackrf_sweeper (https://github.com/subreption/hackrf_sweeper) as a reimplementation of hackrf_sweep. It includes also a 1:1 functional replica of the hackrf_sweep command, besides other demos that could easily be left out of the merge/PR.

The following choices were part of the effort:

  • An unused range for errors was reserved so that it can coexist with hackrf_error definitions as-is.
  • The sweep-related APIs were all documented in their own group for Doxygen.
  • The naming conventions and code style largely match libhackrf's.
  • The library itself should isolate the FFTW dependency to itself.

Our preferred merge approach would be to leave hackrf_sweeper as libhackrf_sweep, limiting the FFTW dependency and leaving the core libhackrf alone. This is how it is done presently and could be easily integrated in the CMake process for libhackrf alone.

@subreption-research subreption-research added the enhancement potential new feature label Sep 30, 2024
@straithe
Copy link
Member

Thank you for letting us know about your efforts. We don't have time in our immediate work schedule to take a look at this, but our team does know about your project now and will take a look as soon as we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement potential new feature
Projects
None yet
Development

No branches or pull requests

2 participants