Skip to content

Fix difference returning NaN with grayscale colors #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix difference returning NaN with grayscale colors #52

wants to merge 1 commit into from

Conversation

e-domnenko
Copy link

@e-domnenko e-domnenko commented Nov 2, 2022 •
edited
Loading

This PR fixes issue #48 in difference function.

difference function returns NaN if one of colours provided as argument is garyscale (e.g. #f0f0f0, #4d4d4d, #eeeeee).

@e-domnenko e-domnenko mentioned this pull request Nov 2, 2022
Open
@lulunac27a
Copy link

The dH formula a^2+b^2-c^2 can be less than zero because of rounding errors caused by floating number precision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-domnenko @lulunac27a