initial porting to python3

Author: hbitsoi

plugins/alleycat/alleycat.py

@@ -19,11 +19,11 @@ def add_to_namespace(namespace, source, name, variable):
     '''
     Add a variable to a different namespace, likely __main__.
     '''
+    import importlib
     importer_module = sys.modules[namespace]
-    if source in sys.modules.keys():
-        reload(sys.modules[source])
+    if source in list(sys.modules.keys()):
+        importlib.reload(sys.modules[source])
     else:
-        import importlib
         m = importlib.import_module(source, None)
         sys.modules[source] = m
 
@@ -56,8 +56,8 @@ def __init__(self, start, end, quiet=False):
         # We work backwards via xrefs, so we start at the end and end at the
         # start
         if not self.quiet:
-            print "Generating call paths from %s to %s..." % (self._name(end),
-                                                              self._name(start))
+            print("Generating call paths from %s to %s..." % (self._name(end),
+                                                              self._name(start)))
         self._build_paths(start, end)
 
     def _name(self, ea):
@@ -442,7 +442,7 @@ def OnDblClick(self, node_id):
         xref_locations = []
         node_ea = self.get_ea_by_name(self[node_id])
 
-        if self.edges.has_key(node_id):
+        if node_id in self.edges:
             for edge_node_id in self.edges[node_id]:
 
                 edge_node_name = self[edge_node_id]
@@ -457,14 +457,14 @@ def OnDblClick(self, node_id):
         if xref_locations:
             xref_locations.sort()
 
-            print ""
-            print "Path Xrefs from %s:" % self[node_id]
-            print "-" * 100
+            print("")
+            print("Path Xrefs from %s:" % self[node_id])
+            print("-" * 100)
             for (xref_ea, dst_ea) in xref_locations:
-                print "%-50s  =>  %s" % (self.get_name_by_ea(xref_ea),
-                                         self.get_name_by_ea(dst_ea))
-            print "-" * 100
-            print ""
+                print("%-50s  =>  %s" % (self.get_name_by_ea(xref_ea),
+                                         self.get_name_by_ea(dst_ea)))
+            print("-" * 100)
+            print("")
 
             ida_shims.jumpto(xref_locations[0][0])
         else:
@@ -571,15 +571,15 @@ def _find_and_plot_paths(self, sources, targets, klass=AlleyCatFunctionPaths):
                 s = time.time()
                 r = klass(source, target).paths
                 e = time.time()
-                print "Found %d paths in %f seconds." % (len(r), (e-s))
+                print("Found %d paths in %f seconds." % (len(r), (e-s)))
 
                 if r:
                     results += r
                 else:
                     name = ida_shims.get_name(target)
                     if not name:
                         name = "0x%X" % target
-                    print "No paths found to", name
+                    print("No paths found to", name)
 
         if results:
             # Be sure to close any previous graph before creating a new one.

plugins/codatify/codatify.py

@@ -66,7 +66,7 @@ def __init__(self, ea, n=16):
                 struct2 = StructCast(address, n)
                 this_pattern = [x.type for x in struct2.entries[p1:p2+1]]
                 if this_pattern == pattern_to_match:
-                    entry_element_count = (address - ea) / self.element_size
+                    entry_element_count = int((address - ea) / self.element_size)
                     break
 
             if entry_element_count is not None and entry_element_count > 0:
@@ -120,7 +120,7 @@ def get_entry_pair(self, structure):
 class Struct(object):
 
     def __init__(self, **kwargs):
-        for (k, v) in kwargs.iteritems():
+        for (k, v) in kwargs.items():
             setattr(self, k, v)
 
 
@@ -159,8 +159,8 @@ def valid_function_name(self, name):
     def search(self):
         patterns = []
 
-        print "Searching for data structure arrays from %s to %s" % \
-              (hex(self.start), hex(self.stop))
+        print("Searching for data structure arrays from %s to %s" % \
+              (hex(self.start), hex(self.stop)))
 
         ea = self.start
         while ea < self.stop:
@@ -186,14 +186,14 @@ def search(self):
                 else:
                     j += 1
 
-            print "Found an array of %d structures at 0x%X - 0x%X. Each " \
+            print("Found an array of %d structures at 0x%X - 0x%X. Each " \
                   "entry has %d elements of %d bytes each." % \
                   (patterns[i].num_entries, patterns[i].start, patterns[i].stop,
-                   patterns[i].num_elements, patterns[i].element_size)
+                   patterns[i].num_elements, patterns[i].element_size))
 
-            print "Array element #%d is the address pointer, and element #%d " \
+            print("Array element #%d is the address pointer, and element #%d " \
                   "is the address pointer name.\n" % \
-                  (patterns[i].function_element, patterns[i].name_element)
+                  (patterns[i].function_element, patterns[i].name_element))
 
             i += 1
 
@@ -213,29 +213,29 @@ def parse_function_tables(self):
                     ea + (pattern.function_element * pattern.element_size))
 
                 new_function_name = ida_shims.get_strlit_contents(
-                    string_address)
+                    string_address).decode("utf8")
                 current_function_name = ida_shims.get_name(function_address)
 
                 if not self.valid_function_name(new_function_name):
-                    print "ERROR: '%s' is not a valid function name. This is " \
+                    print("ERROR: '%s' is not a valid function name. This is " \
                           "likely not a function table, or I have parsed it " \
-                          "incorrectly!" % new_function_name
-                    print "       Ignoring all entries in the structures " \
+                          "incorrectly!" % new_function_name)
+                    print("       Ignoring all entries in the structures " \
                           "between 0x%X and 0x%X.\n" % (pattern.start,
-                                                        pattern.stop)
+                                                        pattern.stop))
                     name2func = {}
                     break
                 elif current_function_name.startswith("sub_"):
                     name2func[new_function_name] = function_address
 
                 ea += (pattern.num_elements * pattern.element_size)
 
-            for (name, address) in name2func.iteritems():
-                print "0x%.8X => %s" % (address, name)
+            for (name, address) in name2func.items():
+                print("0x%.8X => %s" % (address, name))
                 ida_shims.set_name(address, name)
                 count += 1
 
-        print "Renamed %d functions!" % count
+        print("Renamed %d functions!" % count)
 
 
 class FunctionNameology(object):
@@ -254,16 +254,16 @@ def rename_functions(self, debug=True, dry_run=False):
         '''
         count = 0
 
-        for (function_address, function_name) in self.func2str_mappings().iteritems():
+        for (function_address, function_name) in self.func2str_mappings().items():
             if ida_shims.get_name(function_address).startswith("sub_"):
                 if dry_run or ida_shims.set_name(function_address, function_name):
                     if debug:
-                        print "0x%.8X  =>  %s" % (function_address,
-                                                  function_name)
+                        print("0x%.8X  =>  %s" % (function_address,
+                                                  function_name))
                     count += 1
 
         if debug:
-            print "Renamed %d functions based on unique string xrefs!" % count
+            print("Renamed %d functions based on unique string xrefs!" % count)
 
         return count
 
@@ -280,12 +280,12 @@ def func2str_mappings(self):
             if self.is_valid_function_name(str(string)):
                 function_address = self.str2func(string.ea)
                 if function_address is not None:
-                    if not function_map.has_key(function_address):
+                    if function_address not in function_map:
                         function_map[function_address] = []
                     function_map[function_address].append(str(string))
 
         # Each function must have only one candidate string
-        for function_address in function_map.keys():
+        for function_address in list(function_map.keys()):
             if len(function_map[function_address]) == 1:
                 function_map[function_address] = function_map[function_address][0]
             else:
@@ -363,23 +363,23 @@ def stringify(self):
         if ea == idc.BADADDR:
             ea = ida_shims.get_first_seg()
 
-        print "Looking for possible strings starting at: 0x%X..." % ea,
+        print("Looking for possible strings starting at: 0x%X..." % ea, end=' ')
 
         for s in idautils.Strings():
             if s.ea > ea:
                 if not ida_shims.is_strlit(ida_shims.get_full_flags(s.ea)) \
                         and ida_shims.create_strlit(s.ea, 0):
                     n += 1
 
-        print "created %d new ASCII strings" % n
+        print("created %d new ASCII strings" % n)
 
     # Converts remaining data into DWORDS.
     def datify(self):
         ea = self.get_start_ea(self.DATA)
         if ea == idc.BADADDR:
             ea = ida_shims.get_first_seg()
 
-        print "Converting remaining data to DWORDs...",
+        print("Converting remaining data to DWORDs...", end=' ')
 
         while ea != idc.BADADDR:
             flags = ida_shims.get_full_flags(ea)
@@ -391,14 +391,14 @@ def datify(self):
 
             ea = ida_shims.next_addr(ea)
 
-        print "done."
+        print("done.")
 
         self._fix_data_offsets()
 
     def pointify(self):
         counter = 0
 
-        print "Renaming pointers...",
+        print("Renaming pointers...", end=' ')
 
         for (name_ea, name) in idautils.Names():
             for xref in idautils.XrefsTo(name_ea):
@@ -415,13 +415,13 @@ def pointify(self):
                     #else:
                     #    print "Failed to create name '%s'!" % new_name
 
-        print "renamed %d pointers" % counter
+        print("renamed %d pointers" % counter)
 
     def _fix_data_offsets(self):
         ea = 0
         count = 0
 
-        print "Fixing unresolved offset xrefs...",
+        print("Fixing unresolved offset xrefs...", end=' ')
 
         while ea != idaapi.BADADDR:
             (ea, n) = idaapi.find_notype(ea, idaapi.SEARCH_DOWN)
@@ -435,7 +435,7 @@ def _fix_data_offsets(self):
                                         (idaapi.dr_O | idaapi.XREF_USER))
                         count += 1
 
-        print "created %d new data xrefs" % count
+        print("created %d new data xrefs" % count)
 
     # Creates functions and code blocks
     def codeify(self, ea=idc.BADADDR):
@@ -447,8 +447,8 @@ def codeify(self, ea=idc.BADADDR):
             if ea == idc.BADADDR:
                 ea = ida_shims.get_first_seg()
 
-        print "\nLooking for undefined code starting at: %s:0x%X" % \
-              (ida_shims.get_segm_name(ea), ea)
+        print("\nLooking for undefined code starting at: %s:0x%X" % \
+              (ida_shims.get_segm_name(ea), ea))
 
         while ea != idc.BADADDR:
             try:
@@ -466,8 +466,8 @@ def codeify(self, ea=idc.BADADDR):
 
             ea = ida_shims.next_addr(ea)
 
-        print "Created %d new functions and %d new code blocks\n" % \
-              (func_count, code_count)
+        print("Created %d new functions and %d new code blocks\n" % \
+              (func_count, code_count))
 
 
 try:

plugins/funcprofiler/funcprofiler.py

@@ -17,7 +17,7 @@
 
 class IDAProfilerXref(object):
     def __init__(self, **kwargs):
-        for (k, v) in kwargs.iteritems():
+        for (k, v) in kwargs.items():
             setattr(self, k, v)
 
 
@@ -36,7 +36,7 @@ def _build_string_xrefs(self):
                 func = idaapi.get_func(xref.frm)
                 if func:
                     start_ea = ida_shims.start_ea(func)
-                    if not self.functions.has_key(start_ea):
+                    if start_ea not in self.functions:
                         self.functions[start_ea] = list()
 
                     xref = IDAProfilerXref(ea=string.ea, string=key_string,
@@ -49,15 +49,15 @@ def _build_function_xrefs(self):
                 func = idaapi.get_func(xref.frm)
                 if func:
                     start_ea = ida_shims.start_ea(func)
-                    if not self.functions.has_key(start_ea):
+                    if start_ea not in self.functions:
                         self.functions[start_ea] = list()
 
                     self.functions[start_ea].append(IDAProfilerXref(
                         ea=function, string=ida_shims.get_name(function),
                         xref=xref.frm, type=callable))
 
     def _sort_functions(self):
-        for function in self.functions.keys():
+        for function in list(self.functions.keys()):
             self.functions[function] = sorted(self.functions[function],
                                               key=attrgetter('xref'))
 
@@ -124,7 +124,7 @@ def set_internal_filter(self, functions=set(), strings=set()):
     def populate_items(self):
         self.items = []
 
-        for (func_ea, xrefs) in self.profile.functions.iteritems():
+        for (func_ea, xrefs) in self.profile.functions.items():
             if not self.function_filters or func_ea in self.function_filters:
                 orig_items_len = len(self.items)
 
@@ -184,12 +184,12 @@ def rename_regex(self, n, regex_str="", dryrun=False):
 
         if regex_str:
             if dryrun:
-                print "Testing regex rename rule: '%s'" % regex_str
+                print("Testing regex rename rule: '%s'" % regex_str)
 
             regex = re.compile(regex_str)
 
             # Look at all the profiled functions
-            for (function, xrefs) in self.profile.functions.iteritems():
+            for (function, xrefs) in self.profile.functions.items():
                 new_function_name = ""
 
                 # Don't rename functions that have already been renamed
@@ -225,14 +225,14 @@ def rename_regex(self, n, regex_str="", dryrun=False):
                         n += 1
 
                     if dryrun:
-                        print "%s => %s" % (idc.Name(function),
-                                            new_function_name)
+                        print("%s => %s" % (idc.Name(function),
+                                            new_function_name))
                         count += 1
                     else:
                         if ida_shims.set_name(function, new_function_name):
                             count += 1
 
-            print "Renamed %d functions" % count
+            print("Renamed %d functions" % count)
 
 
 def from_function_profiler(arg=None):
@@ -248,15 +248,15 @@ def from_function_profiler(arg=None):
                             "because 0x%X is not inside a function!" % cur_loc)
         chooser.show()
     except Exception as e:
-        print "IDAFunctionProfiler ERROR: %s" % str(e)
+        print("IDAFunctionProfiler ERROR: %s" % str(e))
 
 
 def all_functions_profiler(arg=None):
      try:
         chooser = IDAFunctionProfilerChooser()
         chooser.show()
      except Exception as e:
-        print "IDAFunctionProfiler ERROR: %s" % str(e)
+        print("IDAFunctionProfiler ERROR: %s" % str(e))
 
 
 try: