Switch to ocean polygons #2066
Merged
Switch to ocean polygons #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @imagico |
This avoids having to refactor some landuse types like tidal flats
pnorman
force-pushed
the
water_polygons
branch
from
4a8ccdd
to
04f6d1b
Compare
| @@ -25,7 +25,9 @@ To download the shapefiles you can run the following script from this directory. | |||
| You can also download them manually at the following paths: | |||
|
|
|||
| * [`simplified-land-polygons.shp`](http://data.openstreetmapdata.com/simplified-land-polygons-complete-3857.zip) (updated daily) | |||
There was a problem hiding this comment.
Can this line be removed?
|
Thanks @pnorman! |
|
Unfortunately, I had to revert this change for now as it's still not fully clear what causes #2101. See also #2174. I have created a branch ocean-polygons which can be used for testing the problem (this branch is not intended to be released, it is only there to make testing easier). As soon as #2101 is sorted out, we can again try to move to ocean polygons. |
|
I have reverted this PR for now, see #2101. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have no rendering changes, as the base land and base ocean are still the first things drawn.
We may want to re-order later to put water polygons by ocean polygons, but this will require consideration of what landuse should appear on oceans
Fixes #1982.