-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wetland rendering differentiated by wetland type #1497
Changes from 3 commits
43c3890
113a5b2
7e5c540
4c526e5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
@water-text: #6699cc; | ||
@glacier: #ddecec; | ||
@glacier-line: #9cf; | ||
@mud: #e6dcd1; | ||
|
||
#water-areas { | ||
[natural = 'glacier']::natural { | ||
|
@@ -52,19 +51,37 @@ | |
} | ||
} | ||
} | ||
|
||
[natural = 'mud'][zoom >= 10]::natural { | ||
polygon-fill: @mud; | ||
polygon-pattern-file: url('symbols/mud.png'); | ||
polygon-pattern-alignment: global; | ||
} | ||
} | ||
|
||
#water-areas-overlay { | ||
[natural = 'marsh'], | ||
[natural = 'wetland'] { | ||
[zoom >= 10] { | ||
polygon-pattern-file: url('symbols/wetland.png'); | ||
[zoom >= 10] { | ||
polygon-pattern-file: url('symbols/wetland.png'); | ||
polygon-pattern-alignment: global; | ||
} | ||
[zoom >= 14] { | ||
[int_wetland = 'marsh'], | ||
[int_wetland = 'saltmarsh'], | ||
[int_wetland = 'wet_meadow'], | ||
[int_wetland = 'fen'] { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would drop wetland=fen. It is undocumented and has only 65 instances. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would be fine with me - i included it since it is on http://wiki.openstreetmap.org/wiki/Key:wetland. |
||
polygon-pattern-file: url('symbols/wetland_marsh.png'); | ||
polygon-pattern-alignment: global; | ||
} | ||
[int_wetland = 'reedbed'] { | ||
polygon-pattern-file: url('symbols/wetland_reed.png'); | ||
polygon-pattern-alignment: global; | ||
} | ||
[int_wetland = 'mangrove'] { | ||
polygon-pattern-file: url('symbols/wetland_mangrove.png'); | ||
polygon-pattern-alignment: global; | ||
} | ||
[int_wetland = 'swamp'] { | ||
polygon-pattern-file: url('symbols/wetland_swamp.png'); | ||
polygon-pattern-alignment: global; | ||
} | ||
[int_wetland = 'bog'], | ||
[int_wetland = 'string_bog'] { | ||
polygon-pattern-file: url('symbols/wetland_bog.png'); | ||
polygon-pattern-alignment: global; | ||
} | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be natural_mud?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, in https://github.com/imagico/openstreetmap-carto/blob/wetland-improvements/project.yaml#L151 mud and marsh are translated to wetland types so natural=marsh/mud and natural=wetland+wetland=marsh/mud are treated exactly the same. This could of course also be done in the style sheet but this seems more consistent in result, esp. with regard to priorities in COALESCE() - otherwise a polygon tagged natural=marsh + landuse=* would be rendered different to one tagged natural=wetland + wetland=marsh + landuse=*.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I see now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see.