-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add area render for tourism=attraction #1257
Comments
Where it would be useful? In my experience tourism=attraction is applied to very small object where rendering area is not useful or objects that are rendered anyway. In my experience the only use-case where it maybe would be useful is Speakers' Corner in Hyde Park. EDIT: Added second "In my experience" to make it explicit. |
Below are two examples of attractions that are areas, shown with:
"Den Fynske Landsby" in Odense, Denmark:
"Den Gamle By" in Aarhus, Denmark:
The redish rendering makes it easy to see the extent of the attraction-area. With the current grayish Mapnik-rendering it can be difficult to distinguish the attraction-area from some of the surrounding areas. I think there are many such cases where a distinct coloring of atraction-areas is useful. One additional point: the redish color used for attractions by Cycle and formerly by Mapnik is perhaps too close to the color used for retail and industrial areas. Some adjustnents of these colors could also be useful. Note: In case the rendering is changed,images from the above links can be seen at |
That is an extremely bold statement that unfortunately doesn't hold up. Look at this image of Berlin city centre made with my OSM Renderer for ArcGIS. Just in this small section of the German capital alone, there are at least 7 different **non-**building features tagged with tourism=attraction, including really prominent ones like:
There are many of such non-building tourist marked features world wide... Please click the image to see it properly enlarged. |
2015-01-26 19:43 GMT+01:00 mboeringa notifications@github.com:
+1
yes, but just because they aren't buildings doesn't mean they can't be A tourist attraction is nothing on its own, it is a feature that has the |
I'm usually mapping a lot of area-style touristic attractions in Turkey and China - most of them are historically ruins or archaeological sites - so I feel the _need_ for colored areas. Up to yesterday they where rendered pink which was ok for me... whoever decided to change that back again... :/ |
I thought about rendering it like zoos/theme parks but with subtler border. |
+1 |
sent from a phone
I see this tag as a qualifier, it only makes sense in combination with a tag that says what it is, and when it is present it could raise the "importance level", e.g. it could be rendered/labeled earlier (in terms of rendering order and/or zoom level) than the same object without the tag (I acknowledge that this concept will lead to more complex rendering rules). |
Could you prepare a PR resolving this issue? |
related to #2704 (museum area) |
Sorry, I haven't got the time to start to learn this... Though maybe sometime in the next year or two ;) I really want to try a Docker installation and see what comes out from it. |
I'm against rendering this feature with special outline, because it's very rare case that tourism=attraction is mapped without some other tag which gives the object it's shape/ outline. As I check in Overpass turbo, most of cases where there is only tourism=attraction tag, is just indicative area (there is no fence/ wall etc., but it's just object aproach mapped), so with outline it would give a little bit false information. |
I think that we should not render it as area. Even rendering name is a bit dubious, but rendering it as an area would further discourage from adding also primary tags actually describing the feature. Rendering But for large areas where displaying area would be useful any object should have already a proper tag that should be used. I will not go as far as to propose dropping rendering of |
I agree that current compromise is enough. |
In case that there are some large-scale objects that for some reason can not be tagged with anything except tourism=attraction (I expect that there are no such objects) then let us know in a comment. |
I support this request. I just ran into the problem where an attraction area isn't rendered, neither is the name. Please give it some contrasting colour and display the name. |
@gravitystorm suggests here about tourism=attraction:
The text was updated successfully, but these errors were encountered: