fix IAM joining failing in some cases when a web identity was used as an AWS credential #46764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an AWS credential When the Teleport service attempting to join a cluster using an IAM token was running in FIPS mode in an AWS region without a FIPS STS endpoint, and a web identity token was used as the AWS credential, the local AWS region would be used to build the STS request. We had logic to detect this and fallback to the `us-east-1` region instead, but that was done by passing an additional config to `sts.New`. The config that the AWS `session.Session` contains takes priority over all others. The `us-east-1` region was initially used to build the STS request, but when calling `Request.Sign` on the STS request the URL was changed to use the region configured in the `session.Session`. Instead, rebuild the `session.Session` and STS client `sts.STS` when the region needs to be changed.
capnspacehook
added
aws
This comment was marked as resolved.
This comment was marked as resolved.
rosstimothy
reviewed
Sep 19, 2024
nklaassen
reviewed
Sep 20, 2024
There was a problem hiding this comment.
i'm not sure if this is unit testable, probably tricky, maybe we should add this case to the test plan?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Teleport service attempting to join a cluster using an IAM token was running in FIPS mode in an AWS region without a FIPS STS endpoint, and a web identity token was used as the AWS credential, the local AWS region would be used to build the STS request. We had logic to detect this and fallback to the
us-east-1region instead, but that was done by passing an additional config tosts.New. The config that the AWSsession.Sessioncontains takes priority over all others. Theus-east-1region was initially used to build the STS request, but when callingRequest.Signon the STS request the URL was changed to use the region configured in thesession.Session.Instead, rebuild the
session.Sessionand STS clientsts.STSwhen the region needs to be changed.Fixes https://github.com/gravitational/customer-sensitive-requests/issues/308.
changelog: fix IAM joining failing in some cases when a web identity was used as an AWS credential