Web: Define fetch kube resource web api endpoint #46741
Conversation
kimlisa
added
no-changelog
| @@ -869,6 +869,7 @@ func (h *Handler) bindDefaultEndpoints() { | |||
| // Kube access handlers. | |||
| h.GET("/webapi/sites/:site/kubernetes", h.WithClusterAuth(h.clusterKubesGet)) | |||
| h.GET("/webapi/sites/:site/pods", h.WithClusterAuth(h.clusterKubePodsGet)) | |||
| h.GET("/webapi/sites/:site/kubernetes/resources", h.WithClusterAuth(h.clusterKubeResourcesGet)) | |||
There was a problem hiding this comment.
i added a generic endpoint to allow requesting any kube sub resources @tigrato
There was a problem hiding this comment.
You can drop the h.GET("/webapi/sites/:site/pods", h.WithClusterAuth(h.clusterKubePodsGet)) endpoint.
It was never used and will be replaced by h.GET("/webapi/sites/:site/kubernetes/resources", h.WithClusterAuth(h.clusterKubeResourcesGet))
kimlisa
force-pushed
the
lisa/kube-resource-endpoint
branch
from
d18358f
to
e7a169d
Compare
| @@ -869,6 +869,7 @@ func (h *Handler) bindDefaultEndpoints() { | |||
| // Kube access handlers. | |||
| h.GET("/webapi/sites/:site/kubernetes", h.WithClusterAuth(h.clusterKubesGet)) | |||
| h.GET("/webapi/sites/:site/pods", h.WithClusterAuth(h.clusterKubePodsGet)) | |||
| h.GET("/webapi/sites/:site/kubernetes/resources", h.WithClusterAuth(h.clusterKubeResourcesGet)) | |||
There was a problem hiding this comment.
You can drop the h.GET("/webapi/sites/:site/pods", h.WithClusterAuth(h.clusterKubePodsGet)) endpoint.
It was never used and will be replaced by h.GET("/webapi/sites/:site/kubernetes/resources", h.WithClusterAuth(h.clusterKubeResourcesGet))
lib/web/servers.go
Outdated
| return nil, trace.Wrap(err) | ||
| } | ||
|
|
||
| resp, err := listKubeResources(r.Context(), clt, r.URL.Query(), site.GetName(), r.URL.Query().Get("kind")) |
There was a problem hiding this comment.
can we add a validation on kind?
if kind==""{
return trace.BadParameter..
}
if !slices.Contains(types.KubernetesResources, kind){
return trace.BadParameter(kind is not valid, valid kinds %v, types.KubernetesResources)
}
There was a problem hiding this comment.
done, i also added a check for empty kube cluster since that's also required
kimlisa
force-pushed
the
lisa/kube-resource-endpoint
branch
2 times, most recently
from
080672b
to
c5e423b
Compare
public-teleport-github-review-bot
bot
removed the request for review
from kiosion
part of #46742
Opens a new web api endpoint where we can fetch kube sub resources such as namespaces, pods, secrets, etc (we are currently only utilizing
namespacefor now though)Added all the boilerplate code like adding types etc.