From 0d511a66d113b976f3a44f6ada23e7423517c1ed Mon Sep 17 00:00:00 2001 From: hugoShaka Date: Fri, 15 Nov 2024 12:31:53 -0500 Subject: [PATCH] fix chart typos --- examples/chart/teleport-cluster/templates/_helpers.tpl | 8 ++++---- examples/chart/teleport-cluster/tests/predeploy_test.yaml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/chart/teleport-cluster/templates/_helpers.tpl b/examples/chart/teleport-cluster/templates/_helpers.tpl index 785ef0c2065e8..668e51092ca2a 100644 --- a/examples/chart/teleport-cluster/templates/_helpers.tpl +++ b/examples/chart/teleport-cluster/templates/_helpers.tpl @@ -10,7 +10,7 @@ if serviceAccount is not defined or serviceAccount.name is empty, use .Release.N Create the name of the service account to use in the auth config check hook. If the chart is creating service accounts, we know we can create new arbitrary service accounts. -We cannot reuse the same name as the deployment SA because the non-hook sevrice account might +We cannot reuse the same name as the deployment SA because the non-hook service account might not exist yet. We tried being smart with hooks but ArgoCD doesn't differentiate between install and upgrade, causing various issues on update and eventually forcing us to use a separate SA. @@ -22,7 +22,7 @@ so we can use the same SA for deployments and hooks. {{- include "teleport-cluster.auth.serviceAccountName" . -}} {{- if .Values.serviceAccount.create -}} -hook -{{- end}} +{{- end -}} {{- end -}} {{- define "teleport-cluster.proxy.serviceAccountName" -}} @@ -33,7 +33,7 @@ so we can use the same SA for deployments and hooks. Create the name of the service account to use in the proxy config check hook. If the chart is creating service accounts, we know we can create new arbitrary service accounts. -We cannot reuse the same name as the deployment SA because the non-hook sevrice account might +We cannot reuse the same name as the deployment SA because the non-hook service account might not exist yet. We tried being smart with hooks but ArgoCD doesn't differentiate between install and upgrade, causing various issues on update and eventually forcing us to use a separate SA. @@ -45,7 +45,7 @@ so we can use the same SA for deployments and hooks. {{- include "teleport-cluster.proxy.serviceAccountName" . -}} {{- if .Values.serviceAccount.create -}} -hook -{{- end}} +{{- end -}} {{- end -}} {{- define "teleport-cluster.version" -}} diff --git a/examples/chart/teleport-cluster/tests/predeploy_test.yaml b/examples/chart/teleport-cluster/tests/predeploy_test.yaml index c55b225c5acc3..3ab3ad799e99c 100644 --- a/examples/chart/teleport-cluster/tests/predeploy_test.yaml +++ b/examples/chart/teleport-cluster/tests/predeploy_test.yaml @@ -212,7 +212,7 @@ tests: path: spec.template.spec.serviceAccountName value: helm-test-sa-hook - - it: should use serviceAccount.name for auth predeploy job SA when set in values and we're not cretaing SAs + - it: should use serviceAccount.name for auth predeploy job SA when set in values and we're not creating SAs template: auth/predeploy_job.yaml set: clusterName: helm-lint @@ -244,7 +244,7 @@ tests: path: spec.template.spec.serviceAccountName value: helm-test-sa-proxy-hook - - it: should use serviceAccount.name for proxy predeploy job SA when set in values and we're not cretaing SAs + - it: should use serviceAccount.name for proxy predeploy job SA when set in values and we're not creating SAs template: proxy/predeploy_job.yaml set: clusterName: helm-lint