Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible buffer overflow in wa.c #1

Open
mappu opened this issue Apr 11, 2019 · 2 comments
Open

Possible buffer overflow in wa.c #1

mappu opened this issue Apr 11, 2019 · 2 comments

Comments

@mappu
Copy link

mappu commented Apr 11, 2019

Hi! Super cool project.

It was posted on HN today at https://news.ycombinator.com/item?id=19617652 and one user had this to say:

This line: https://github.com/grassel/wac-esp/blob/master/main/wa.c#L683

What prevents me from writing a wasm file with an arbitrary value for "depth" greater than CALLSTACK_SIZE (1024) and overflowing the buffer? (If the answer is "nothing", that's probably arbitrary code execution.)

@grassel
Copy link
Owner

grassel commented Apr 11, 2019

Thanks - I saw the comment on HN myself. - I will look into this.

1 similar comment
@grassel
Copy link
Owner

grassel commented Apr 11, 2019

Thanks - I saw the comment on HN myself. - I will look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants