-
Notifications
You must be signed in to change notification settings - Fork 1.1k
field merging - field TYPES must not differ #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not true; the field types do not have to be the same, they just have to be compatible. Please read http://spec.graphql.org/draft/#FieldsInSetCanMerge() carefully and consider fields with polymorphic types (unions and interfaces). The text as currently stated in the spec is, however, correct.
so, "scalar values must not differ" - it is correct? which values? we are at early validation stage, we do not have any values yet. I thought it should say something about types; ok, maybe not require the exact same types, then pls help to formulate the proper short phrase describing 'type' requirements |
You could change the word "values" to "types" I suppose. |
Co-authored-by: Benjie <benjie@jemjie.com>
Minor correction, Editorial.