Skip to content

Rename VariableDefinitions to VariablesDefinition #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2022
Merged

Rename VariableDefinitions to VariablesDefinition #916

merged 5 commits into from
Jun 2, 2022

Conversation

sungam3r
Copy link
Contributor

@sungam3r sungam3r commented Jan 4, 2022

fixes #915

@netlify
Copy link

netlify bot commented Jan 4, 2022 •
edited
Loading

✅ Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit b65328e
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/62992c7f0527590008da6ebd
😎 Deploy Preview https://deploy-preview-916--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sungam3r
Copy link
Contributor Author

sungam3r commented Jan 4, 2022

Should I revert changelogs/October2021.md ?

@benjie
Copy link
Member

benjie commented Jan 4, 2022

Yes, revert that 👍

@sungam3r
Copy link
Contributor Author

sungam3r commented Jan 5, 2022

done

@benjie
Copy link
Member

benjie commented Jan 5, 2022 •
edited
Loading

To keep this tight, lets roll back the changes to section 6 too. Make the replacement case sensitive. I note that we use argumentDefinitions in the algorithms but ArgumentsDefinition in the syntax, and I think that's fine because they refer to subtly different concepts.

@sungam3r
Copy link
Contributor Author

sungam3r commented Jan 6, 2022

done

@benjie benjie added the ✏️ Editorial PR is non-normative or does not influence implementation label Jan 11, 2022
@leebyron leebyron merged commit 266fcca into graphql:main Jun 2, 2022
@benjie benjie mentioned this pull request Feb 21, 2025
Merged
@benjie benjie mentioned this pull request Mar 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
✏️ Editorial PR is non-normative or does not influence implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question about naming
3 participants
@sungam3r @benjie @leebyron