Skip to content

Commit e068b64

Browse files
authored
Merge branch 'main' into add-accurate-duration-and-nominal-duration
2 parents dd51be9 + 6402d3e commit e068b64

File tree

3 files changed

+22
-19
lines changed

3 files changed

+22
-19
lines changed

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,13 @@ this project.
2727
[graphql-scalars GitHub repository](https://github.com/graphql/graphql-scalars/tree/main/scalars).
2828

2929
2. Modify your selected template, and save it in the correct place
30-
`scalars/contributed/<github-user-name>/<scalar-name>.md` in the
30+
`scalars/contributed/<github-user-or-organization-name>/<scalar-name>.md` in
31+
the
3132
[graphql-scalars GitHub repository](https://github.com/graphql/graphql-scalars/tree/main/scalars/contributed).
3233
The directory location is important, as this will form part of the reference
33-
URL for your specification.
34+
URL for your specification. In case you are using an organization name, we
35+
will manually verify that you are allowed to make the contribution in the
36+
name of the organization.
3437

3538
3. Install dependencies with `npm install` and the run `npm run build` to
3639
locally build the resulting public specification files. Navigate to the

scalars/contributed/andimarek/date-time.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Author - andimarek
66

77
Date - 2022-10-18
88

9-
This is a String-based Scalar.
9+
This is a String-based scalar.
1010

1111
**License and Copyright**
1212

@@ -15,11 +15,11 @@ Copyright © GraphQL contributors. This specification is licensed under
1515

1616
# Overview
1717

18-
This Scalar represents an exact point in time. This point in time is specified
18+
This scalar represents an exact point in time. This point in time is specified
1919
by having an offset to UTC and does **not** use a time zone.
2020

2121
It is a slightly refined version of
22-
[RFC 3339](https://tools.ietf.org/html/rfc3339) including the
22+
[RFC 3339](https://tools.ietf.org/html/rfc3339), including the
2323
[errata](https://www.rfc-editor.org/errata/rfc3339).
2424

2525
All definitions of RFC 3339 are adopted and nothing is added or removed unless
@@ -32,7 +32,7 @@ The following refinements/clarifications apply:
3232
This scalar represents a “date-time” as specified in section 5.6 of RFC 3339.
3333

3434
The other productions in section 5.6 are only used to support "date-time" but
35-
never stand alone for this Scalar.
35+
never stand alone for this scalar.
3636

3737
**Non-optional exact milliseconds**
3838

@@ -42,14 +42,14 @@ RFC 3339 defines `time-secfrac` optional as:
4242
time-secfrac = "." 1*DIGIT (Meaning 1 or more DIGIT)
4343
```
4444

45-
This allows for an unlimited numbers of digits. For this scalar the rule is not
46-
optional anymore and refined as:
45+
This allows for an unlimited number of digits. For this scalar, the rule is no
46+
longer optional and is refined as:
4747

4848
```
4949
time-secfrac = "." DIGIT DIGIT DIGIT
5050
```
5151

52-
consisting always of exact three digits representing milliseconds.
52+
... consisting always of exactly three digits representing milliseconds.
5353

5454
**No 'Unknown Local Offset Convention'**
5555

@@ -60,7 +60,7 @@ If the time in UTC is known, but the offset to local time is unknown,
6060
this can be represented with an offset of "-00:00".
6161
```
6262

63-
In order to simplify this Scalar this convention is dropped and an offset of
63+
In order to simplify this scalar this convention is dropped and an offset of
6464
`-00:00` is not allowed.
6565

6666
**Examples**
@@ -87,20 +87,20 @@ These are invalid examples:
8787
| ---------------------------------- | ------------------------------------------------------------------ |
8888
| `2011-08-30T13:22:53.108-03` | The minutes of the offset are missing. |
8989
| `2011-08-30T13:22:53.108912Z` | Too many digits for fractions of a second. Exactly three expected. |
90-
| `2011-08-30T24:22:53Z` | Fractions of a second are missing. |
90+
| `2011-08-30T23:22:53Z` | Fractions of a second are missing. |
9191
| `2011-08-30T13:22:53.108` | No offset provided. |
9292
| `2011-08-30` | No time provided. |
9393
| `2011-08-30T13:22:53.108-00:00` | Negative offset (`-00:00`) is not allowed |
9494
| `2011-08-30T13:22:53.108+03:30:15` | Seconds are not allowed for the offset |
9595
| `2011-08-30T24:22:53.108Z` | `24` is not allowed as hour of the time. |
9696
| `2010-02-30T21:22:53.108Z` | 30th of February is not a valid date |
97-
| `2010-02-11T21:22:53.108Z+25:11` | 25 is not a valid hour for offset |
97+
| `2010-02-11T21:22:53.108+25:11` | 25 is not a valid hour for offset |
9898

9999
# Name
100100

101101
The recommended name is `DateTime`. An alternative is `OffsetDateTime`.
102102

103-
`Date` is potentially misleading as this Scalar also specifies a time, not only
103+
`Date` is potentially misleading as this scalar also specifies a time, not only
104104
a date.
105105

106106
# Result
@@ -111,4 +111,4 @@ two divider characters `T` and `Z` are always uppercase, never `t` or `z`.
111111

112112
# Input
113113

114-
As Input every valid String as described above must be accepted.
114+
As input, every valid String as described above must be accepted.

scalars/contributed/andimarek/local-date.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
"Date - 2023-01-18"
88

9-
This is a String-based Scalar.
9+
This is a String-based scalar.
1010

1111
**License and Copyright**
1212

@@ -18,7 +18,7 @@ Copyright © GraphQL contributors. This specification is licensed under
1818
This scalar represents a date without a time-zone in the
1919
[ISO-8601](https://en.wikipedia.org/wiki/ISO_8601) calendar system.
2020

21-
The pattern is "YYYY-MM-DD" with "YYYY" representing the year, "MM" the month
21+
The pattern is "YYYY-MM-DD" with "YYYY" representing the year, "MM" the month,
2222
and "DD" the day.
2323

2424
Valid examples are "1983-10-20" or "2023-04-01". An invalid example would be
@@ -27,7 +27,7 @@ Valid examples are "1983-10-20" or "2023-04-01". An invalid example would be
2727
The prefix "Local" comes from the fact that without a time-zone it is not a
2828
specific point in time, but rather expresses a "local point of view". A popular
2929
use case for using this scalar are birthdays for example, which are normally not
30-
stored with a specific timezone.
30+
stored with a specific time zone.
3131

3232
Because this scalar depends on the ISO-8601 calendar it is not recommended to
3333
use for dates before the year 1582.
@@ -36,11 +36,11 @@ use for dates before the year 1582.
3636

3737
The recommended name is "LocalDate".
3838

39-
# Result spec
39+
# Result
4040

4141
Every result must follow the pattern "YYYY-MM-DD" as described above.
4242

43-
# Input spec
43+
# Input
4444

4545
Every input must follow the pattern "YYYY-MM-DD" as described above.
4646

0 commit comments

Comments
 (0)