-
Notifications
You must be signed in to change notification settings - Fork 2k
Implement onError proposal (but with ErrorBehavior
rather than __ErrorBehavior
)
#4384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.x.x
Are you sure you want to change the base?
Conversation
Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
This comment has been minimized.
This comment has been minimized.
@benjie The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
@github-actions publish-pr-on-npm |
@@ -37,6 +37,7 @@ describe('Star Wars Introspection Tests', () => { | |||
{ name: 'Droid' }, | |||
{ name: 'Query' }, | |||
{ name: 'Boolean' }, | |||
{ name: 'ErrorBehavior' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure whether we should expose this as a schema
property, this is in fact an internal property that tells us just how a GraphQL API will behave. Most GraphQL code I've seen treats it as such where when walking the introspection there is an explicit check for properties starting with __
to be skipped.
Alternative to:
Using
__ErrorBehavior
causes older GraphiQL to baulk. I'm hoping that this approach will not.