Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow object types without fields. #368

Closed
wants to merge 1 commit into from
Closed

Allow object types without fields. #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/type/__tests__/validation-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,18 +355,6 @@ describe('Type System: Objects must have fields', () => {
);
});

it('rejects an Object type with empty fields', () => {
expect(
() => schemaWithFieldType(new GraphQLObjectType({
name: 'SomeObject',
fields: {}
}))
).to.throw(
'SomeObject fields must be an object with field names as keys or a ' +
'function which returns such an object.'
);
});

it('rejects an Object type with a field function that returns nothing', () => {
expect(
() => schemaWithFieldType(new GraphQLObjectType({
Expand All @@ -381,20 +369,6 @@ describe('Type System: Objects must have fields', () => {
);
});

it('rejects an Object type with a field function that returns empty', () => {
expect(
() => schemaWithFieldType(new GraphQLObjectType({
name: 'SomeObject',
fields() {
return {};
}
}))
).to.throw(
'SomeObject fields must be an object with field names as keys or a ' +
'function which returns such an object.'
);
});

});


Expand Down
9 changes: 1 addition & 8 deletions src/type/definition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,15 +385,8 @@ function defineFieldMap(
'function which returns such an object.'
);

const fieldNames = Object.keys(fieldMap);
invariant(
fieldNames.length > 0,
`${type} fields must be an object with field names as keys or a ` +
'function which returns such an object.'
);

const resultFieldMap = {};
fieldNames.forEach(fieldName => {
Object.keys(fieldMap).forEach(fieldName => {
assertValidName(fieldName);
const field = {
...fieldMap[fieldName],
Expand Down