Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: small refactors within execute #3638

Merged
merged 4 commits into from
Jun 13, 2022
Merged

refactor: small refactors within execute #3638

merged 4 commits into from
Jun 13, 2022

Commits on Jun 12, 2022

  1. refactor: move assertValidExecutionArguments into `buildExecutionCo… 

    …ntext`

`assertValidExecutionArguments` is only called immediately prior to `buildExecutionContext` and `buildExecutionContext` is never called without  calling `assertValidExecutionArguments` immediately prior.
    @yaacovCR
    yaacovCR committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    639b9d8 View commit details
    Browse the repository at this point in the history

  2. refactor: remove rootValue argument from executeOperation 

    `executeOperation` is never called with a `rootValue` different from `exeContext.rootValue` and `rootValue` is not utilized in the calling code except to pass its value to `executeOperation`. Rather than using an additional argument to `executeOperation`, the `rootValue`, the `rootValue` can be selected from the `exeContext` within `executeOperation`
    @yaacovCR
    yaacovCR committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    2332de5 View commit details
    Browse the repository at this point in the history

  3. refactor: pass through args to buildExecutionContext

    @yaacovCR
    yaacovCR committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    3a17407 View commit details
    Browse the repository at this point in the history

  4. refactor: remove null from executeOperation return type 

    not actually possible!
    @yaacovCR
    yaacovCR committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    15dafb8 View commit details
    Browse the repository at this point in the history