Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint GitHub Actions #3614

Merged
merged 1 commit into from
May 28, 2022
Merged

Lint GitHub Actions #3614

merged 1 commit into from
May 28, 2022

Conversation

IvanGoncharov
Copy link
Member

Right now we pass NPM token in github action and plan to have automatic
releases that is why it is critical to lint action files.
I didn't find any JS-based solution and the only validator I could find
is https://github.com/rhysd/actionlint

Right now we pass NPM token in github action and plan to have automatic
releases that is why it is critical to lint action files.
I didn't find any JS-based solution and the only validator I could find
is https://github.com/rhysd/actionlint
@netlify
Copy link

netlify bot commented May 28, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 561f9f0
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6292603f8de9e40008295996
😎 Deploy Preview https://deploy-preview-3614--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@IvanGoncharov IvanGoncharov merged commit fe8b664 into graphql:main May 28, 2022
@IvanGoncharov IvanGoncharov deleted the pr_branch2 branch May 28, 2022 18:29
@yaacovCR
Copy link
Contributor

This seems to be causing tests to be skipped silently. See #3616 where tests are not run.

Available message in log:

docker://rhysd/actionlint:latest is not allowed to be used in graphql/graphql-js. Actions in this workflow must be: within a repository owned by graphql, created by GitHub, or matching the following: codecov/codecov-action@v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants