Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for astFromValue #2180

Closed
wants to merge 1 commit into from
Closed

Improve documentation for astFromValue #2180

wants to merge 1 commit into from

Conversation

wtrocki
Copy link
Contributor

@wtrocki wtrocki commented Sep 17, 2019

Minor fix to improve comment/documentation for astFromValue function

@wtrocki wtrocki closed this Sep 17, 2019
@wtrocki wtrocki deleted the patch-1 branch September 17, 2019 09:42
@IvanGoncharov
Copy link
Member

@wtrocki It's was the useful change you just forget to run prettier.
So please feel free to reopen it and just run npm run prettier and commit changes.

@wtrocki
Copy link
Contributor Author

wtrocki commented Sep 17, 2019

Closed this one and reopened new one (#2182)
Sorry for confusion.

@IvanGoncharov
Copy link
Member

@wtrocki No problem.
Tip: you can do git commit --ammend -av & git push -f. It's totally normal to do force push in PRs.

This was referenced Jan 28, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtrocki @IvanGoncharov